Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/artesca 10858 empty state #715

Merged
merged 43 commits into from
Jun 4, 2024
Merged

Improvement/artesca 10858 empty state #715

merged 43 commits into from
Jun 4, 2024

Conversation

JeanMarcMilletScality
Copy link
Contributor

Component:

Description:

Design:

Breaking Changes:

  • [] Breaking Changes

Closes: #ISSUE_NUMBER

@bert-e
Copy link
Contributor

bert-e commented Feb 27, 2024

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 27, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Feb 28, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Feb 29, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 1, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 451e5d3 to a850ce8 Compare March 1, 2024 13:06
@bert-e
Copy link
Contributor

bert-e commented Mar 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 8, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality marked this pull request as ready for review March 8, 2024 13:06
@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from b9e241c to aa1e276 Compare March 18, 2024 16:12
@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 0a5de24 to aa1e276 Compare March 18, 2024 17:15
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 2ccbe4e to 7c40d1f Compare March 21, 2024 10:21
@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch 5 times, most recently from 8cc0ffb to 74094fc Compare March 26, 2024 09:32
@bert-e
Copy link
Contributor

bert-e commented Mar 26, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality
JBWatenbergScality reviewed Apr 4, 2024
View reviewed changes
src/lib/components/infomessage/InfoMessageUtils.ts Outdated Show resolved Hide resolved
src/lib/components/tablev2/Tablestyle.tsx Outdated Show resolved Hide resolved
src/lib/components/tablev2/Tablestyle.tsx Outdated Show resolved Hide resolved
src/lib/components/emptystate/Emptystate.component.tsx Outdated Show resolved Hide resolved
src/lib/components/tablev2/Search.tsx Show resolved Hide resolved
src/lib/components/tablev2/Tablestyle.tsx Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Apr 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
add import of react
f1730ab
@JeanMarcMilletScality
add entity and status props to Table
ea43f7a
@JeanMarcMilletScality
add an object with messages in en and fr for empty and loading state
6d5e410
@JeanMarcMilletScality
add TableRows for empty table or rows rendering, move common elements…
557482d 
… of singleSelectable and MultiSelectable to TableCommon
@JeanMarcMilletScality
add gap and vertical align so empty and loading state style is consis…
692dd4c 
…tent with table row
@JeanMarcMilletScality
update stories
e9598fa
@JeanMarcMilletScality
change entity for entityName
d34c6b9
@JeanMarcMilletScality
add spacing between columns
d9e9fd3
@JeanMarcMilletScality
remove displayTotalOf dprecated prop, remove displayName as entityNam…
8682f1d 
…e is in table context
@JeanMarcMilletScality
fr entityName optionnal
6ac5f46
@JeanMarcMilletScality
change prop and condition as fr is now optionnal
af0f23c
@JeanMarcMilletScality
add resourceToCreate in EmptyState, change displayed text when an oth…
a403fda 
…er resource is needed before crzating the list resource
@JeanMarcMilletScality
remove border right for non selected row, and remove backgroundVarian…
812c78c 
…t prop defining the color of the border
@JeanMarcMilletScality
add an optional background prop to empty state
6399fb3
@JeanMarcMilletScality
add padding left in rows, comment head row width calc as it change no…
6600e65 
…thing with scrollbar
@JeanMarcMilletScality
remove console.log
4792eeb
@JeanMarcMilletScality
add box sizing borderbox to avoid border being not visible in UIs. re…
bfc9b47 
…move the margin top to sidebar to avoid gap between border
@JeanMarcMilletScality
fix typo
60c1296
@JeanMarcMilletScality
remove trailing bracket, change for new spacing
69d4b31
@JeanMarcMilletScality
add padding in search box container
e85f76d
@JeanMarcMilletScality
restore margin-top
fabe869
@JeanMarcMilletScality
need to calc width with scrollbar
2da8a24
@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 74094fc to 2da8a24 Compare April 5, 2024 14:15
JBWatenbergScality
JBWatenbergScality approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue ARTESCA-10858.

Goodbye jeanmarcmilletscality.

@bert-e bert-e merged commit 8250a7c into development/1.0 Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeanMarcMilletScality @bert-e @JBWatenbergScality