Improvement/artesca 11384 light theme polishing #704
Conversation
…rs, remove getThemePropSelector
Hello jeanmarcmilletscality,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stories/searchinput.stories.tsx
Outdated
| console.log('args', args); | ||
| console.log('value', value); |
…nput size to avoid overlap with close button
| const StyledInput = styled.input` | ||
| max-width: 100%; | ||
| const StyledInput = styled.input<{ hasIcon: boolean }>` | ||
| max-width: calc(100% - 1rem - ${spacing.f8}); |
There was a problem hiding this comment.
SHouldn't we remove 1rem - ${spacing.f8} only when we have an icon ?
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue ARTESCA-11384. Goodbye jeanmarcmilletscality. |
Component:
Description:
Design:
Breaking Changes:
Closes: #ISSUE_NUMBER