Update global health component #275

ChengYanJin · 2021-03-23T10:25:01Z

Component: Global Health Component

Description:
As the first interaction, we decided to only display the global health alert exclude the alerts one layer below.

Design:

Update:

Update:

Closes: #186

bert-e · 2021-03-23T10:25:03Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-03-23T10:25:07Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-03-23T10:27:33Z

Conflict

There is a conflict between your branch improvement/update-global-health-component and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (improvement/update-global-health-component).

 $ git fetch
 $ git checkout origin/improvement/update-global-health-component
 $ git merge origin/development/1.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/update-global-health-component

bert-e · 2021-03-23T10:28:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-03-23T10:58:22Z

Conflict

There is a conflict between your branch improvement/update-global-health-component and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (improvement/update-global-health-component).

 $ git fetch
 $ git checkout origin/improvement/update-global-health-component
 $ git merge origin/development/1.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/update-global-health-component

bert-e · 2021-03-23T11:02:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

src/lib/components/globalhealthbar/GlobalHealthBar.component.js

src/lib/components/vegachart/VegaChart.component.js

bert-e · 2021-03-23T13:29:54Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@JBWatenbergScality

Cuervino · 2021-03-23T16:34:35Z

Time legend - Nicer to have "01 Feb" on the same line (and not on 2 lines)
Proposal: maybe add super small stick bars for having a better period division
A little bit disturbing for me that there is no action/popup on the green sections (even with a "0 alert" tooltip), but that's just a feeling
Hovering behavior issue/bug:
When hovering on, the focus (color highlight) + the tooltip
When hovering out, the focus stays (it should come back to normal), and the tooltip disappears (correct). Currently, no way to switch back to the "original" status.
https://user-images.githubusercontent.com/28654802/112181861-1463be80-8bfd-11eb-9799-12a2282b295c.mp4
For the popup/tooltip

Nicer to change the border to 313131
I would propose to remove the opacity of the bg (on the PR it's 90%, but as we are not using it currently anywhere else in the UI, I would avoid it)
The font Family is not Lato, I'd change it for Lato

The design of the pop-up might be enhanced later on (for instance, adding an icon next to severity).

bert-e · 2021-03-25T09:33:30Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@JBWatenbergScality

bert-e · 2021-03-26T10:26:33Z

Conflict

There is a conflict between your branch improvement/update-global-health-component and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (improvement/update-global-health-component).

 $ git fetch
 $ git checkout origin/improvement/update-global-health-component
 $ git merge origin/development/1.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/update-global-health-component

Refs: #186

bert-e · 2021-03-28T15:59:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@JBWatenbergScality

ChengYanJin · 2021-03-29T09:00:42Z

Time legend - Nicer to have "01 Feb" on the same line (and not on 2 lines)

Haven't found a solution for this. But I think it's not a block for the moment, maybe we can create a ticket to tract all the improvement need to be done around global health component.

Proposal: maybe add super small stick bars for having a better period division

(Please check the change). I try to achieve the best I can do.

A little bit disturbing for me that there is no action/popup on the green sections (even with a "0 alert" tooltip), but that's just a feeling

What I can do is display the same tooltip(without description and title, because no alert trigger in this period)

Hovering behavior issue/bug:
When hovering on, the focus (color highlight) + the tooltip
When hovering out, the focus stays (it should come back to normal), and the tooltip disappears (correct). Currently, no way to switch back to the "original" status.
https://user-images.githubusercontent.com/28654802/112181861-1463be80-8bfd-11eb-9799-12a2282b295c.mp4

Issue solved. Thanks for pointing this issue!

For the popup/tooltip

Nicer to change the border to 313131

I would propose to remove the opacity of the bg (on the PR it's 90%, but as we are not using it currently anywhere else in the UI, I would avoid it)

The font Family is not Lato, I'd change it for Lato

The design of the pop-up might be enhanced later on (for instance, adding an icon next to severity).

Customized the tooltip.

JBWatenbergScality · 2021-03-29T09:31:31Z

src/lib/components/globalhealthbar/GlobalHealthBar.component.js

+              domainWidth: 0,
+              tickCount: 7,
+              labelExpr:
+                "[timeFormat(datum.value, '%d'), timeFormat(datum.value, '%d') == '01' ? timeFormat(datum.value, '%b') : '']",


shouldn't we always display the month for the first point ? (for example a graph starting on 7 February and ending on 14th won't display any month information so I'm wondering if displaying the month on the first displayed day could help to understand that we are displaying dates here )

Update with:

bert-e · 2021-03-31T14:51:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2021-03-31T15:20:36Z

/approve

ChengYanJin · 2021-03-31T15:30:31Z

/status

bert-e · 2021-03-31T15:32:29Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2021-03-31T15:34:51Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-03-31T15:38:55Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.0

Please check the status of the associated issue None.

Goodbye chengyanjin.

ChengYanJin requested review from MonPote, Cuervino and JBWatenbergScality March 23, 2021 10:25

ChengYanJin force-pushed the improvement/update-global-health-component branch from 9210092 to b4e3bc0 Compare March 23, 2021 10:28

ChengYanJin force-pushed the improvement/update-global-health-component branch from 24b1004 to bed32db Compare March 23, 2021 11:02

ChengYanJin force-pushed the improvement/update-global-health-component branch 2 times, most recently from acac2e5 to 59d3ecb Compare March 23, 2021 11:35

JBWatenbergScality requested changes Mar 23, 2021

View reviewed changes

ChengYanJin force-pushed the improvement/update-global-health-component branch from 59d3ecb to 62bf287 Compare March 25, 2021 09:33

ChengYanJin force-pushed the improvement/update-global-health-component branch 3 times, most recently from 0fe2d52 to 2a113f9 Compare March 26, 2021 10:22

ChengYanJin force-pushed the improvement/update-global-health-component branch from 2a113f9 to 69fe3c6 Compare March 28, 2021 15:53

ChengYanJin added 2 commits March 28, 2021 17:58

dependency: Bump the vega-lite version to v5

58a350a

Refs: #186

statusbar: Remove the statusbar related

1bbf1ec

ChengYanJin force-pushed the improvement/update-global-health-component branch from 69fe3c6 to 49dcff1 Compare March 28, 2021 15:59

ChengYanJin force-pushed the improvement/update-global-health-component branch from 49dcff1 to e724f39 Compare March 29, 2021 08:45

ChengYanJin requested a review from JBWatenbergScality March 29, 2021 08:45

globalhealth: Add component display only top level alert

3a818ba

vegachart: Add customized tooltip

187ce0f

JBWatenbergScality reviewed Mar 29, 2021

View reviewed changes

ChengYanJin force-pushed the improvement/update-global-health-component branch from e724f39 to d0b6860 Compare March 30, 2021 14:19

Update the snapshot

3b7441d

ChengYanJin requested a review from JBWatenbergScality March 30, 2021 14:40

ChengYanJin force-pushed the improvement/update-global-health-component branch from d0b6860 to 7ec8098 Compare March 30, 2021 14:42

globalhealth: Address the no corner radius alert trigger at beginning

7ec8098

JBWatenbergScality approved these changes Mar 31, 2021

View reviewed changes

bert-e merged commit c813670 into development/1.0 Mar 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update global health component #275

Update global health component #275

ChengYanJin commented Mar 23, 2021 •

edited

Loading

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

bert-e commented Mar 23, 2021

Cuervino commented Mar 23, 2021

bert-e commented Mar 25, 2021

bert-e commented Mar 26, 2021

bert-e commented Mar 28, 2021

ChengYanJin commented Mar 29, 2021 •

edited

Loading

JBWatenbergScality Mar 29, 2021

ChengYanJin Mar 30, 2021 •

edited

Loading

bert-e commented Mar 31, 2021

ChengYanJin commented Mar 31, 2021

ChengYanJin commented Mar 31, 2021

bert-e commented Mar 31, 2021

bert-e commented Mar 31, 2021

bert-e commented Mar 31, 2021

Update global health component #275

Update global health component #275

Conversation

ChengYanJin commented Mar 23, 2021 • edited Loading

bert-e commented Mar 23, 2021

Hello chengyanjin,

bert-e commented Mar 23, 2021

Waiting for approval

bert-e commented Mar 23, 2021

Conflict

bert-e commented Mar 23, 2021

Waiting for approval

bert-e commented Mar 23, 2021

Conflict

bert-e commented Mar 23, 2021

Waiting for approval

bert-e commented Mar 23, 2021

Waiting for approval

Cuervino commented Mar 23, 2021

bert-e commented Mar 25, 2021

Waiting for approval

bert-e commented Mar 26, 2021

Conflict

bert-e commented Mar 28, 2021

Waiting for approval

ChengYanJin commented Mar 29, 2021 • edited Loading

JBWatenbergScality Mar 29, 2021

Choose a reason for hiding this comment

ChengYanJin Mar 30, 2021 • edited Loading

Choose a reason for hiding this comment

bert-e commented Mar 31, 2021

Waiting for approval

ChengYanJin commented Mar 31, 2021

ChengYanJin commented Mar 31, 2021

bert-e commented Mar 31, 2021

Status

bert-e commented Mar 31, 2021

In the queue

bert-e commented Mar 31, 2021

ChengYanJin commented Mar 23, 2021 •

edited

Loading

ChengYanJin commented Mar 29, 2021 •

edited

Loading

ChengYanJin Mar 30, 2021 •

edited

Loading