Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLDSRV-388] ✨ Implement GHAS #5169

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[CLDSRV-388] ✨ Implement GHAS #5169

merged 1 commit into from
Jun 13, 2023

Conversation

gaspardmoindrot
Copy link
Contributor

@gaspardmoindrot gaspardmoindrot commented May 22, 2023 •
edited
Loading

Pull request template

Description

Motivation and context

In the interest of security, it is important, even essential, to regularly perform code and image scans to identify any security vulnerabilities. In line with this, the changes made in this PR will enable the implementation of GitHub Advanced Security principles within this repository. This includes the implementation of workflow files that allow performing regular scans.

Related issues

None

Checklist

Add tests to cover the changes

No tests to add since it's only workflow files, it doesn't directly impact the code.

Code conforms with the style guide

Sign your work

Signed-off-by: Gaspard Moindrot [email protected]

@gaspardmoindrot gaspardmoindrot self-assigned this May 22, 2023
@bert-e
Copy link
Contributor

bert-e commented May 22, 2023

Hello gaspardmoindrot,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 22, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-388 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.21

Please check the Fix Version/s of CLDSRV-388, or the target
branch of this pull request.

@gaspardmoindrot
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented May 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@gaspardmoindrot gaspardmoindrot marked this pull request as draft May 22, 2023 18:52
@gaspardmoindrot gaspardmoindrot changed the title [CLDSRV-388] ✨ Implememt GHAS [CLDSRV-388] ✨ Implement GHAS May 24, 2023
@gaspardmoindrot gaspardmoindrot force-pushed the improvement/CLDSRV-388-implement-GHAS branch from 05401a6 to a40de2a Compare May 24, 2023 22:02
@gaspardmoindrot gaspardmoindrot changed the base branch from development/8.7 to development/7.4 May 24, 2023 22:03
@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-388 contains:

  • 8.7.21

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.28

  • 7.4.12

  • 7.70.21

  • 8.5.21

  • 8.6.10

  • 8.7.21

Please check the Fix Version/s of CLDSRV-388, or the target
branch of this pull request.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 24, 2023
View reviewed changes
bin/search_bucket.js Fixed Show fixed Hide fixed
@gaspardmoindrot gaspardmoindrot force-pushed the improvement/CLDSRV-388-implement-GHAS branch from a40de2a to cc6d71b Compare May 24, 2023 22:35
@gaspardmoindrot gaspardmoindrot force-pushed the improvement/CLDSRV-388-implement-GHAS branch from a996dfa to 57fb5f1 Compare May 24, 2023 22:39
@gaspardmoindrot
Copy link
Contributor Author

ping

@gaspardmoindrot gaspardmoindrot marked this pull request as ready for review May 24, 2023 22:42
@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Integration data created

I have created the integration data for the additional destination branches.

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@tcarmet tcarmet requested review from a team, jonathan-gramain, watsaqat and cmeichel-scality and removed request for a team May 24, 2023 22:53
jonathan-gramain
jonathan-gramain approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to be checked if development/7.4 is the right target

@bert-e
Copy link
Contributor

bert-e commented May 30, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-388 contains:

  • 7.10.28

  • 7.4.12

  • 7.70.21

  • 8.5.21

  • 8.6.10

  • 8.7.22

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.28

  • 7.4.12

  • 7.70.21

  • 8.5.21

  • 8.6.10

  • 8.7.24

Please check the Fix Version/s of CLDSRV-388, or the target
branch of this pull request.

@gaspardmoindrot
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jun 12, 2023
@bert-e
Copy link
Contributor

bert-e commented Jun 12, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.4

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.5

  • ✔️ development/8.6

  • ✔️ development/8.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@gaspardmoindrot
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 13, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.4

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.5

  • ✔️ development/8.6

  • ✔️ development/8.7

Please check the status of the associated issue CLDSRV-388.

Goodbye gaspardmoindrot.

@bert-e bert-e merged commit 57fb5f1 into development/7.4 Jun 13, 2023
@bert-e bert-e deleted the improvement/CLDSRV-388-implement-GHAS branch June 13, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

@tcarmet tcarmet tcarmet approved these changes

@nootal nootal Awaiting requested review from nootal

@watsaqat watsaqat Awaiting requested review from watsaqat watsaqat was automatically assigned from scality/object

@cmeichel-scality cmeichel-scality Awaiting requested review from cmeichel-scality cmeichel-scality was automatically assigned from scality/object

Assignees

@gaspardmoindrot gaspardmoindrot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaspardmoindrot @bert-e @jonathan-gramain @tcarmet