Skip to content

Conversation

@francoisferrand
Copy link
Contributor

details.lastModified must not be set in the kafka message, as it's purpose is to let the object-processor make an extra check that the “object” was not modified (i.e. no new version).
This is done through a s3:HeadObject call on the object, (without versionId), which:

  • is not relevant for `NCVE (if anything, we may instead check that the versionId being expired is indeed not the current one)
  • in particular may fail is the current version is a delete markers)

Issue: BB-726

details.lastModified must not be set in the kafka message, as it's
purpose is to let the object-processor make an extra check that the
“object” was not modified (i.e. no new version) : this is done through a
`s3:HeadObject` call on the object, (without versionId), which:
- is not relevant for NCVE (if anything, we may instead check that the
versionId being expired is indeed not the current one)
- in particular may fail is the current version is a delete markers)

Issue: BB-726
@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@francoisferrand francoisferrand requested review from a team, DarkIsDude, SylvainSenechal and anurag4DSB and removed request for a team, DarkIsDude and anurag4DSB November 9, 2025 17:16
@francoisferrand
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Nov 10, 2025
@bert-e
Copy link
Contributor

bert-e commented Nov 10, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue BB-726.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 9dae48d into development/8.6 Nov 10, 2025
9 checks passed
@bert-e bert-e deleted the bugfix/BB-726 branch November 10, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants