Improvement/bb 514 handle lifecycle rules #2548

benzekrimaha · 2024-10-01T13:46:32Z

bert-e · 2024-10-01T13:46:36Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-10-01T13:46:41Z

Incorrect fix version

The Fix Version/s in issue BB-514 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.7.0

Please check the Fix Version/s of BB-514, or the target
branch of this pull request.

codecov · 2024-10-01T13:48:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.41%. Comparing base (92520d5) to head (45393de).
Report is 12 commits behind head on development/8.7.

Additional details and impacted files

Files with missing lines	Coverage Δ
extensions/lifecycle/LifecycleConfigValidator.js	`83.33% <ø> (ø)`
extensions/lifecycle/tasks/LifecycleTask.js	`88.82% <100.00%> (-0.02%)`	⬇️
extensions/lifecycle/util/rules.js	`100.00% <100.00%> (ø)`
lib/config/configItems.joi.js	`96.15% <100.00%> (+0.15%)`	⬆️
lib/constants.js	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Bucket Notification	`66.66% <ø> (ø)`
Core Library	`74.15% <100.00%> (+0.02%)`	⬆️
Ingestion	`68.70% <ø> (ø)`
Lifecycle	`74.91% <100.00%> (-0.01%)`	⬇️
Oplog Populator	`82.95% <ø> (ø)`
Replication	`57.42% <ø> (ø)`
Bucket Scanner	`85.76% <ø> (ø)`

@@               Coverage Diff                @@
##           development/8.7    #2548   +/-   ##
================================================
  Coverage            69.40%   69.41%           
================================================
  Files                  194      194           
  Lines                12792    12792           
================================================
+ Hits                  8878     8879    +1     
+ Misses                3904     3903    -1     
  Partials                10       10

Flag	Coverage Δ
api:retry	`9.67% <25.00%> (+<0.01%)`	⬆️
api:routes	`9.57% <25.00%> (+<0.01%)`	⬆️
bucket-scanner	`85.76% <ø> (ø)`
ingestion	`12.48% <25.00%> (+<0.01%)`	⬆️
lib	`7.57% <25.00%> (+0.01%)`	⬆️
lifecycle	`19.39% <100.00%> (ø)`
notification	`0.88% <0.00%> (ø)`
replication	`18.97% <25.00%> (+<0.01%)`	⬆️
unit	`43.01% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Issue : BB-514

bert-e · 2024-10-02T12:35:49Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

conf/config.json

francoisferrand · 2024-10-02T13:09:46Z

extensions/lifecycle/tasks/LifecycleTask.js

@@ -3,7 +3,6 @@
 const async = require('async');
 const { errors, versioning } = require('arsenal');
 const { ObjectMD } = require('arsenal').models;


we need to create a ticket to remove this from Arsenal, eventually
(i.e. after we have migrated all branches to this new backbeat)

Ticket created here => https://scality.atlassian.net/browse/ARSN-435

tests/config.json

francoisferrand · 2024-10-02T13:12:00Z

extensions/lifecycle/LifecycleConfigValidator.js

@@ -67,6 +67,13 @@ const joiSchema = joi.object({
    coldStorageRestoreAdjustTopicPrefix: joi.string().default('cold-restore-adjust-req-'),
    coldStorageGCTopicPrefix: joi.string().default('cold-gc-req-'),
    coldStorageStatusTopicPrefix: joi.string().default('cold-status-'),
+    supportedLifecycleRules: joi.array().items(joi.string()).default([


we may also want to validate each item from this list : i.e. to ensure each value is indeed of the potentially supported rule type

done here : 1d60534#diff-4ddf07d1cd40d3d68a85bcf7ab41f36f43094af8cfc0e93424067c48bd03b623R70-R78

tests/config.json

williamlardier · 2024-10-07T08:39:29Z

extensions/lifecycle/LifecycleConfigValidator.js

+        Joi.string().valid(
+            'expiration',
+            'noncurrentVersionExpiration',
+            'abortIncompleteMultipartUpload',
+            'transitions',
+            'noncurrentVersionTransition'
+        )
+    ).default([
+        'expiration',
+        'noncurrentVersionExpiration',
+        'abortIncompleteMultipartUpload',
+        'transitions',
+        'noncurrentVersionTransition',
+    ]),


Could this array be a constant in a single place?
Something like this (not tested)

Suggested change

Joi.string().valid(

'expiration',

'noncurrentVersionExpiration',

'abortIncompleteMultipartUpload',

'transitions',

'noncurrentVersionTransition'

)

).default([

'expiration',

'noncurrentVersionExpiration',

'abortIncompleteMultipartUpload',

'transitions',

'noncurrentVersionTransition',

]),

Joi.string().valid(...supportedLifecycleRules)

).default(supportedLifecycleRules),

williamlardier · 2024-10-08T12:11:05Z

lib/config/configItems.joi.js

@@ -150,6 +151,10 @@ const qpKafkaJoi = kafkaJoi.append({
    replication: extensionKafkaJoi,
 });

+const supportedLifecycleRulesJoi =  joi.array().items(


Suggested change

const supportedLifecycleRulesJoi = joi.array().items(

const supportedLifecycleRulesJoi = joi.array().items(

(maybe not very useful to store this one here if we only use it once, but the array can stay here)

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from ac34e2f to bdedb98 Compare October 2, 2024 11:46

benzekrimaha requested a review from Kerkesni October 2, 2024 11:50

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from e70ec89 to 3bf7414 Compare October 2, 2024 12:33

supported lifecycle rules in bb lifecycle config instead of const

7b654e0

Issue : BB-514

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from 3bf7414 to 7b654e0 Compare October 2, 2024 12:34

benzekrimaha marked this pull request as ready for review October 2, 2024 12:34

francoisferrand reviewed Oct 2, 2024

View reviewed changes

conf/config.json Outdated Show resolved Hide resolved

francoisferrand reviewed Oct 2, 2024

View reviewed changes

tests/config.json Outdated Show resolved Hide resolved

francoisferrand reviewed Oct 2, 2024

View reviewed changes

benzekrimaha requested a review from francoisferrand October 7, 2024 08:35

williamlardier reviewed Oct 7, 2024

View reviewed changes

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from 56bdcc6 to 7b738ea Compare October 7, 2024 19:53

fixup post review

f953ffd

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from 7b738ea to f953ffd Compare October 7, 2024 20:07

fixup post review

45393de

benzekrimaha force-pushed the improvement/BB-514-handle-lifecycle-rules branch from fca5311 to 45393de Compare October 8, 2024 11:05

williamlardier approved these changes Oct 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/bb 514 handle lifecycle rules #2548

Improvement/bb 514 handle lifecycle rules #2548

benzekrimaha commented Oct 1, 2024 •

edited

Loading

bert-e commented Oct 1, 2024

bert-e commented Oct 1, 2024

codecov bot commented Oct 1, 2024 •

edited

Loading

bert-e commented Oct 2, 2024

francoisferrand Oct 2, 2024

benzekrimaha Oct 7, 2024 •

edited

Loading

francoisferrand Oct 2, 2024

benzekrimaha Oct 7, 2024

williamlardier Oct 7, 2024

williamlardier Oct 8, 2024

williamlardier Oct 8, 2024

	const supportedLifecycleRulesJoi = joi.array().items(
	const supportedLifecycleRulesJoi = joi.array().items(

Improvement/bb 514 handle lifecycle rules #2548

Are you sure you want to change the base?

Improvement/bb 514 handle lifecycle rules #2548

Conversation

benzekrimaha commented Oct 1, 2024 • edited Loading

bert-e commented Oct 1, 2024

Hello benzekrimaha,

bert-e commented Oct 1, 2024

Incorrect fix version

codecov bot commented Oct 1, 2024 • edited Loading

Codecov Report

bert-e commented Oct 2, 2024

Waiting for approval

francoisferrand Oct 2, 2024

Choose a reason for hiding this comment

benzekrimaha Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

francoisferrand Oct 2, 2024

Choose a reason for hiding this comment

benzekrimaha Oct 7, 2024

Choose a reason for hiding this comment

williamlardier Oct 7, 2024

Choose a reason for hiding this comment

williamlardier Oct 8, 2024

Choose a reason for hiding this comment

williamlardier Oct 8, 2024

Choose a reason for hiding this comment

benzekrimaha commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading

benzekrimaha Oct 7, 2024 •

edited

Loading