Update mongodb dashboard JSON#2222
Conversation
5178d24 to
cab8e0c
Compare
a456566 to
ac679cf
Compare
cab8e0c to
2f9daba
Compare
7494d02 to
be74526
Compare
d3be7fc to
d3f8a9d
Compare
869fb15 to
f1872ee
Compare
fa66847 to
9062ee2
Compare
f1872ee to
7de6191
Compare
8944786 to
ed4be0c
Compare
ed4be0c to
1f703a1
Compare
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/feature/ZENKO-5003-mongodb-dashboard && \
git merge origin/development/2.12Resolve merge conflicts and commit git push origin HEAD:feature/ZENKO-5003-mongodb-dashboard |
| "Disk IO Utilization (all instances)", | ||
| [ | ||
| Target( | ||
| expr=f'sum by(pod) (rate(container_blkio_device_usage_total{{operation="Total", namespace="{NAMESPACE}", pod=~".*mongodb.*"}}[$__rate_interval]))', |
There was a problem hiding this comment.
Must keep pod here, as this is not a mongodb exported metric... I will define and use POD_PATTERN in several places, for these metrics. I think it is valuable to keep these panels in this dashboard, even if not directly exported by mongodb, because it gives the big picture that we are often missing in current dashboards... But please challenge if you disagree.
There was a problem hiding this comment.
should not be a POD_PATTERN (hardcoded in the dashboard code), but rely on inputs specified by ZKOP.
(or create a -hidden- template parameter which extracts the values of pod label from the up{job=...} query, to get this list)
bb31033 to
5445921
Compare
|
@francoisferrand : The PR mesage was updated with the new dashboard image. I checked one by one and I resolved all comments, plus some related. Just one thing, I changed (removed) the Jobs class to just use it as an input from the dashboard:
Please tell me if you had something else in mind. |
| ] | ||
|
|
||
|
|
||
| class MongoDBMetrics: |
There was a problem hiding this comment.
does not seem solved?
did you create a cleanup ticket for later?
6c6591c to
ee343a3
Compare
The current dashboard proved to be useles in production, not useful in case of issues, hard to debug and have the big picture. This commit introduces a complete rework based on all knowledge we gained over time. - Refactored the MongoDB dashboard JSON configuration to enhance structure and readability. - Introduced a new Python script for generating MongoDB metrics using grafanalib, including common thresholds and state mappings. - Updated panel configurations and added new metrics for better monitoring capabilities. Modernize dashboard logic - Use statically verifiable types for dev time checks - Ensure we use a more human readable "job" - Rename variables - Improve consistency across panels Reduce code duplication Also rename mongodb_instance_type to jobs. Use variable and not sting when possible. Issue: ZENKO-5003
ee343a3 to
aa47923
Compare
|
/after_pull_request 2240 |
|
/approve |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-5003. Goodbye williamlardier. |

Issue: ZENKO-5003
The scalgrafanalib integration will be done in ZENKO-5010
updated Jul 21 11pm