Skip to content

Update mongodb dashboard JSON#2222

Merged
bert-e merged 1 commit intodevelopment/2.12from
feature/ZENKO-5003-mongodb-dashboard
Jul 29, 2025
Merged

Update mongodb dashboard JSON#2222
bert-e merged 1 commit intodevelopment/2.12from
feature/ZENKO-5003-mongodb-dashboard

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 13, 2025

Issue: ZENKO-5003

The scalgrafanalib integration will be done in ZENKO-5010

updated Jul 21 11pm

screencapture-10-160-103-37-8443-grafana-d-besmvgi5ovd34d-mongodb57-2025-07-21-23_07_06

@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch from 5178d24 to cab8e0c Compare May 13, 2025 12:46
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch from a456566 to ac679cf Compare May 13, 2025 13:56
@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch from cab8e0c to 2f9daba Compare May 19, 2025 10:03
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch 2 times, most recently from 7494d02 to be74526 Compare May 21, 2025 13:52
@ghost ghost marked this pull request as ready for review May 21, 2025 14:10
@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch 8 times, most recently from d3be7fc to d3f8a9d Compare May 26, 2025 14:25
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch 2 times, most recently from 869fb15 to f1872ee Compare May 27, 2025 09:21
@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch from fa66847 to 9062ee2 Compare May 27, 2025 09:43
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch from f1872ee to 7de6191 Compare May 27, 2025 09:43
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json
Comment thread monitoring/mongodb/dashboard.json
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
Comment thread monitoring/mongodb/dashboard.json Outdated
@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch 3 times, most recently from 8944786 to ed4be0c Compare June 5, 2025 09:41
@ghost ghost force-pushed the feature/ZENKO-4641-v2 branch from ed4be0c to 1f703a1 Compare July 1, 2025 13:08
Base automatically changed from feature/ZENKO-4641-v2 to development/2.12 July 1, 2025 14:58
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 1, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 1, 2025

Conflict

There is a conflict between your branch feature/ZENKO-5003-mongodb-dashboard and the
destination branch development/2.12.

Please resolve the conflict on the feature branch (feature/ZENKO-5003-mongodb-dashboard).

git fetch && \
git checkout origin/feature/ZENKO-5003-mongodb-dashboard && \
git merge origin/development/2.12

Resolve merge conflicts and commit

git push origin HEAD:feature/ZENKO-5003-mongodb-dashboard

Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
"Disk IO Utilization (all instances)",
[
Target(
expr=f'sum by(pod) (rate(container_blkio_device_usage_total{{operation="Total", namespace="{NAMESPACE}", pod=~".*mongodb.*"}}[$__rate_interval]))',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must keep pod here, as this is not a mongodb exported metric... I will define and use POD_PATTERN in several places, for these metrics. I think it is valuable to keep these panels in this dashboard, even if not directly exported by mongodb, because it gives the big picture that we are often missing in current dashboards... But please challenge if you disagree.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be a POD_PATTERN (hardcoded in the dashboard code), but rely on inputs specified by ZKOP.

(or create a -hidden- template parameter which extracts the values of pod label from the up{job=...} query, to get this list)

Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py
Comment thread monitoring/mongodb/dashboard.py Outdated
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch from bb31033 to 5445921 Compare July 21, 2025 12:02
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 21, 2025

@francoisferrand : The PR mesage was updated with the new dashboard image. I checked one by one and I resolved all comments, plus some related. Just one thing, I changed (removed) the Jobs class to just use it as an input from the dashboard:

image

Please tell me if you had something else in mind.

@ghost ghost requested a review from francoisferrand July 21, 2025 12:25
Comment thread monitoring/mongodb/dashboard.py Outdated
]


class MongoDBMetrics:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem solved?
did you create a cleanup ticket for later?

Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
@ghost ghost requested a review from francoisferrand July 21, 2025 21:07
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py Outdated
@ghost ghost requested a review from francoisferrand July 22, 2025 19:02
Comment thread monitoring/mongodb/dashboard.py Outdated
Comment thread monitoring/mongodb/dashboard.py
Comment thread monitoring/mongodb/dashboard.py Outdated
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch from 6c6591c to ee343a3 Compare July 28, 2025 07:20
  The current dashboard proved to be useles in production, not useful in case of issues, hard to debug and have the big picture. This commit introduces a complete rework based on all knowledge we gained over time.
- Refactored the MongoDB dashboard JSON configuration to enhance structure and readability.
- Introduced a new Python script for generating MongoDB metrics using grafanalib, including common thresholds and state mappings.
- Updated panel configurations and added new metrics for better monitoring capabilities.

Modernize dashboard logic

- Use statically verifiable types for dev time checks
- Ensure we use a more human readable "job"
- Rename variables
- Improve consistency across panels

Reduce code duplication

Also rename mongodb_instance_type to jobs.
Use variable and not sting when possible.

Issue: ZENKO-5003
@ghost ghost force-pushed the feature/ZENKO-5003-mongodb-dashboard branch from ee343a3 to aa47923 Compare July 28, 2025 07:44
@francoisferrand
Copy link
Copy Markdown
Contributor

/after_pull_request 2240

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2025

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-5003 contains:

  • 2.12.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.12.5

Please check the Fix Version/s of ZENKO-5003, or the target
branch of this pull request.

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.12

The following branches will NOT be impacted:

  • development/2.10
  • development/2.11
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.12

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-5003.

Goodbye williamlardier.

@bert-e bert-e merged commit 0d7610b into development/2.12 Jul 29, 2025
27 of 28 checks passed
@bert-e bert-e deleted the feature/ZENKO-5003-mongodb-dashboard branch July 29, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants