ZENKO-4905-check-patches-on-ci

[benzekrimaha]

Issue: ZENKO-4905

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[francoisferrand]

should not filter patches: if we need not to apply it, then we must actually remove it (git rm)...

Suggested change

	PATCH_FILES:=$(shell ls ${PATCH_DIR}/* | grep -v mongodb-sharded-add-configsvr-service-file.patch)
	PATCH_FILES:=$(shell ls ${PATCH_DIR}/*)

[francoisferrand]

Nit: Why this change?

[francoisferrand]

why do we need to remove?
if this is needed, should be part of a patch...

(if helm does not does remove "external" files, then we may need remove the whole chart folder in make fetch-mongodb-sharded)

[benzekrimaha]

no the file isn't there when we fetch de mongo sharded , it has always been added manually , the chart creates it. That's why here I remove it otherwise i end up with an error saying that the file already exists ( I don't have the historic linked to this)

[francoisferrand]

that is an issue in the patch file,

--- /dev/null
+++ b/solution-base/mongodb/charts/mongodb-sharded/templates/config-server/config-server-service.yaml

and should be fixed by updating the patchfile, not the process.

[francoisferrand]

Just tested:

• "updating" the charts does not actually remove files which were created... So upgrading "in-place" just overwrites the files, but leaves removed files in place...
• the patches work when we simply delete the charts directory before fetching: however, this causes the git diff to fail as we added some files:

  supprimé :        charts/mongodb-sharded/charts/common/values.schema.json
  supprimé :        charts/mongodb-sharded/files/docker-entrypoint-initdb.d/create-app-user-sharded.sh
  supprimé :        charts/mongodb-sharded/files/docker-entrypoint-initdb.d/set-default-write-concern-majority-sharded.sh
  supprimé :        charts/mongodb-sharded/templates/initialization-configmap.yaml
  

• Regarding config-server-service.yaml, this file is indeed not present in the chart: not related to patching, but I wonder why we added it (or kept it), and if we need it still...

• clearing the folder before fetch is the way
• need to update the patch files to "create" these removed files/links
• need to review if we still need values.schema.json, initialization-configmap.yaml and config--server-service.yaml

[benzekrimaha]

/approve

[benzekrimaha]

/wait

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following options are set: approve