Upgrade CTST deps #2146

williamlardier · 2024-09-05T15:18:27Z

Bump CTST dependencies

Also, adapt the code to follow the scality rules, as well as the typescript recommended rules.

bert-e · 2024-09-05T15:18:31Z

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-09-06T07:21:09Z

Incorrect fix version

The Fix Version/s in issue ZENKO-4882 contains:

2.10.0
2.8.43
2.9.18

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.10.0
2.6.67
2.7.63
2.8.43
2.9.18

Please check the Fix Version/s of ZENKO-4882, or the target
branch of this pull request.

bert-e · 2024-09-06T07:21:17Z

Incorrect fix version

The Fix Version/s in issue ZENKO-4882 contains:

2.10.0
2.7.63
2.8.43
2.9.18

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.10.0
2.6.67
2.7.63
2.8.43
2.9.18

Please check the Fix Version/s of ZENKO-4882, or the target
branch of this pull request.

bert-e · 2024-09-06T07:22:24Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

francoisferrand · 2024-09-16T07:07:20Z

tests/ctst/eslint.config.mjs

+            '**/.vscode',
+            '**/vendor/*.js',
+            '**/build',
+            '**/coverage',
+            '**/dist',
+            '**/node_modules/**/*',
+            '**/package',
+            '**/reports',
+            '**/eslint.config.mjs',


instead of replicating what is (in large part) in .gitignore, should "import" this file with includeIgnoreFile(gitignorePath) [1]

[1] https://eslint.org/docs/latest/use/configure/ignore#including-gitignore-files

it works well (but the cost is another dev dependency....)

francoisferrand · 2024-09-16T07:11:51Z

tests/ctst/features/resource-policies/regen.js

@@ -152,21 +152,26 @@ const output = scenarios.map(scenario => {
    const paddedBucketPolicyApplies = scenario.bucketPolicyApplies.padEnd(longest.bucketPolicyApplies);
    const paddedBucketPolicyEffect = scenario.bucketPolicyEffect.padEnd(longest.bucketPolicyEffect);

+    // eslint-disable-next-line max-len


shouldn't we reformat instead:

Suggested change

// eslint-disable-next-line max-len

return (

` `, paddedAction, paddedBucketPolicyExists. paddedBucketPolicyApplies,

paddedBucketPolicyEffect, paddedIamPolicyExists, paddedIamPolicyApplies, paddedIamPolicyEffect,

).join(' | )

francoisferrand · 2024-09-16T07:13:24Z

tests/ctst/tsconfig.json

@@ -26,6 +26,7 @@
      // "strictPropertyInitialization": true,  /* Enable strict checking of property initialization in classes. */
      "noImplicitThis": true,                   /* Raise error on 'this' expressions with an implied 'any' type. */
      // "alwaysStrict": true,                  /* Parse in strict mode and emit "use strict" for each source file. */
+      "skipLibCheck": true,


do we really want to save compilation time at the expense of type-system accuracy?

It is because of issues with some libs we do not control, e.g.:

node_modules/cli-testing/node_modules/@aws-sdk/client-s3/dist-types/auth/httpAuthSchemeProvider.d.ts:1:10 - error TS2724: '"@aws-sdk/core"' has no exported member named 'AwsSdkSigV4AAuthInputConfig'. Did you mean 'AwsSdkSigV4AuthInputConfig'?

And one vaultclient issue (ticket is VLTCLT-52):

node_modules/vaultclient/lib/IAMClient.d.ts:266:100 - error TS1016: A required parameter cannot follow an optional parameter. 266 verifySignatureV4(stringToSign: string, signature: string, accessKey: string, region?: string, scopeDate: string, options: {

I will try to remove this line when the sdk is more up to date.

- Remove unused dependencies - Use scality eslint rules - Use recommended typescript eslint rules Issue: ZENKO-4882

Issue: ZENKO-4882

- Ignore files through the gitignore file - Avoid ignoring eslint rule when we can improve the code Issue: ZENKO-4882

williamlardier · 2024-09-18T07:06:37Z

/create_integration_branches

bert-e · 2024-09-18T07:09:01Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ZENKO-4882 into
development/2.6
w/2.7/improvement/ZENKO-4882 will be merged into development/2.7
w/2.8/improvement/ZENKO-4882 will be merged into development/2.8
w/2.9/improvement/ZENKO-4882 will be merged into development/2.9
w/2.10/improvement/ZENKO-4882 will be merged into development/2.10

The following branches will NOT be impacted:

development/2.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2024-09-18T07:09:02Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

williamlardier · 2024-09-19T19:08:18Z

/approve

bert-e · 2024-09-19T19:08:34Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.6
✔️ development/2.7
✔️ development/2.8
✔️ development/2.9
✔️ development/2.10

The following branches have NOT changed:

development/2.5

Please check the status of the associated issue ZENKO-4882.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches

williamlardier force-pushed the improvement/ZENKO-4882 branch 2 times, most recently from 6982d6d to c1ec6b7 Compare September 6, 2024 07:15

williamlardier marked this pull request as ready for review September 6, 2024 07:19

scality deleted a comment from bert-e Sep 6, 2024

williamlardier force-pushed the improvement/ZENKO-4882 branch from c1ec6b7 to a22a859 Compare September 6, 2024 07:22

francoisferrand reviewed Sep 16, 2024

View reviewed changes

francoisferrand approved these changes Sep 16, 2024

View reviewed changes

williamlardier added 4 commits September 18, 2024 08:47

Bump eslint to v9

401f461

- Remove unused dependencies - Use scality eslint rules - Use recommended typescript eslint rules Issue: ZENKO-4882

Bump dependencies

fe694a5

Issue: ZENKO-4882

Update code to match linter rules

baeb728

Issue: ZENKO-4882

Improve linting

b32b58c

- Ignore files through the gitignore file - Avoid ignoring eslint rule when we can improve the code Issue: ZENKO-4882

williamlardier force-pushed the improvement/ZENKO-4882 branch from a22a859 to b32b58c Compare September 18, 2024 06:57

williamlardier requested review from Kerkesni and benzekrimaha September 18, 2024 06:58

scality deleted a comment from bert-e Sep 18, 2024

Kerkesni approved these changes Sep 18, 2024

View reviewed changes

benzekrimaha approved these changes Sep 18, 2024

View reviewed changes

bert-e merged commit b32b58c into development/2.6 Sep 19, 2024
14 checks passed

bert-e deleted the improvement/ZENKO-4882 branch September 19, 2024 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade CTST deps #2146

Upgrade CTST deps #2146

williamlardier commented Sep 5, 2024 •

edited

Loading

bert-e commented Sep 5, 2024

bert-e commented Sep 6, 2024

bert-e commented Sep 6, 2024

bert-e commented Sep 6, 2024

francoisferrand Sep 16, 2024

williamlardier Sep 18, 2024

francoisferrand Sep 16, 2024

francoisferrand Sep 16, 2024

williamlardier Sep 18, 2024

williamlardier commented Sep 18, 2024

bert-e commented Sep 18, 2024

bert-e commented Sep 18, 2024

williamlardier commented Sep 19, 2024

bert-e commented Sep 19, 2024

-    // eslint-disable-next-line max-len
+return (
+	`           `, paddedAction, paddedBucketPolicyExists. paddedBucketPolicyApplies,
+	paddedBucketPolicyEffect, paddedIamPolicyExists, paddedIamPolicyApplies, paddedIamPolicyEffect,
+).join(' | )

Upgrade CTST deps #2146

Upgrade CTST deps #2146

Conversation

williamlardier commented Sep 5, 2024 • edited Loading

bert-e commented Sep 5, 2024

Hello williamlardier,

bert-e commented Sep 6, 2024

Incorrect fix version

bert-e commented Sep 6, 2024

Incorrect fix version

bert-e commented Sep 6, 2024

Request integration branches

francoisferrand Sep 16, 2024

Choose a reason for hiding this comment

williamlardier Sep 18, 2024

Choose a reason for hiding this comment

francoisferrand Sep 16, 2024

Choose a reason for hiding this comment

francoisferrand Sep 16, 2024

Choose a reason for hiding this comment

williamlardier Sep 18, 2024

Choose a reason for hiding this comment

williamlardier commented Sep 18, 2024

bert-e commented Sep 18, 2024

Integration data created

bert-e commented Sep 18, 2024

Waiting for approval

williamlardier commented Sep 19, 2024

bert-e commented Sep 19, 2024

williamlardier commented Sep 5, 2024 •

edited

Loading