impr(ARSN-529): Add RateLimitConfiguration to BucketInfo #2568

tmacro · 2025-11-05T00:50:30Z

No description provided.

bert-e · 2025-11-05T00:50:33Z

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-11-05T00:50:38Z

Incorrect fix version

The Fix Version/s in issue ARSN-529 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.4.0

Please check the Fix Version/s of ARSN-529, or the target
branch of this pull request.

codecov · 2025-11-05T00:55:37Z

Codecov Report

❌ Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.41%. Comparing base (2a414c8) to head (7de5056).
⚠️ Report is 1 commits behind head on development/8.2.

Files with missing lines	Patch %	Lines
lib/models/BucketInfo.ts	75.00%	4 Missing ⚠️
lib/s3routes/routes/routePUT.ts	40.00%	3 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2568      +/-   ##
===================================================
+ Coverage            71.40%   71.41%   +0.01%     
===================================================
  Files                  221      222       +1     
  Lines                17816    17851      +35     
  Branches              3681     3689       +8     
===================================================
+ Hits                 12721    12749      +28     
- Misses                5091     5098       +7     
  Partials                 4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anurag4DSB · 2025-11-05T10:45:02Z

are we sure about the target branch 8.3 is not released yet with stable aws sdk upgrade, we might not be able to test.

anurag4DSB · 2025-11-05T20:26:38Z

are we sure about the target branch 8.3 is not released yet with stable aws sdk upgrade, we might not be able to test.

I am okay, we have a feature branch in cloudserver, which we can test on.

bert-e · 2025-11-06T16:10:08Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

tmacro · 2025-11-06T17:00:33Z

/create_integration_branches

bert-e · 2025-11-06T17:00:43Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARSN-529/rate_limit_config_model into
development/8.2
w/8.3/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.3
w/8.4/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.4

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-11-06T17:00:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

anurag4DSB · 2025-11-08T20:18:17Z

lib/s3routes/routes/routePUT.ts

                        200, log);
                });
+        } else if (query['rate-limit'] !== undefined) {
+            api.callApiMethod('bucketGetRateLimit', request, response,


Shouldn't this be bucketPutRateLimit

anurag4DSB · 2025-11-08T20:18:47Z

lib/s3routes/routes/routeDELETE.ts

        } else if (query?.quota !== undefined) {
            return call('bucketDeleteQuota');
+        } else if (query?.['rate-limit'] !== undefined) {
+            return call('bucketDeleteQuota');


for this one, bucketDeleteRateLimit?

anurag4DSB · 2025-11-08T20:20:28Z

lib/errors/arsenalErrors.ts


+export const NoSuchRateLimitConfig: ErrorFormat = {
+    code: 404,
+    description: 'The specified bucket does not have a rate limit configuration.',


This one is more compact, what do you think?
(also looking at other configuration messages
The bucket rate limit configuration does not exist.

or
The bucket rate limit configuration was not found
like:
The object lock configuration was not found'
The replication configuration was not found

bert-e · 2025-11-12T17:42:19Z

History mismatch

Merge commit #ee3ed13eb0e998dd3600a08926147e2b508132a9 on the integration branch
w/8.3/improvement/ARSN-529/rate_limit_config_model is merging a branch which is neither the current
branch improvement/ARSN-529/rate_limit_config_model nor the development branch
development/8.3.

It is likely due to a rebase of the branch improvement/ARSN-529/rate_limit_config_model and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

tmacro · 2025-11-12T18:26:05Z

/reset

bert-e · 2025-11-12T18:26:14Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:26:25Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARSN-529/rate_limit_config_model into
development/8.2
w/8.3/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.3
w/8.4/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.4

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:26:26Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:31:13Z

History mismatch

Merge commit #fd1d771a3f7478085217ba13a60e69d8e38a9a6a on the integration branch
w/8.3/improvement/ARSN-529/rate_limit_config_model is merging a branch which is neither the current
branch improvement/ARSN-529/rate_limit_config_model nor the development branch
development/8.3.

It is likely due to a rebase of the branch improvement/ARSN-529/rate_limit_config_model and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

tmacro · 2025-11-12T18:31:21Z

/reset

bert-e · 2025-11-12T18:31:29Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:31:39Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARSN-529/rate_limit_config_model into
development/8.2
w/8.3/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.3
w/8.4/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.4

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:31:40Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:39:52Z

History mismatch

Merge commit #4ba516583e71bf98622d1ec4f7198522771fcbc8 on the integration branch
w/8.3/improvement/ARSN-529/rate_limit_config_model is merging a branch which is neither the current
branch improvement/ARSN-529/rate_limit_config_model nor the development branch
development/8.3.

It is likely due to a rebase of the branch improvement/ARSN-529/rate_limit_config_model and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

tmacro · 2025-11-12T18:39:59Z

/reset

bert-e · 2025-11-12T18:40:08Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:40:18Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARSN-529/rate_limit_config_model into
development/8.2
w/8.3/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.3
w/8.4/improvement/ARSN-529/rate_limit_config_model will be merged into development/8.4

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-11-12T18:40:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tmacro · 2025-11-14T16:11:57Z

/approve

bert-e · 2025-11-14T16:12:10Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.2
✔️ development/8.3
✔️ development/8.4

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

Please check the status of the associated issue ARSN-529.

Goodbye tmacro.

The following options are set: approve, create_integration_branches

anurag4DSB approved these changes Nov 5, 2025

View reviewed changes

tcarmet approved these changes Nov 5, 2025

View reviewed changes

tmacro changed the base branch from development/8.4 to development/8.2 November 6, 2025 16:08

scality deleted a comment from bert-e Nov 6, 2025

anurag4DSB reviewed Nov 8, 2025

View reviewed changes

tmacro force-pushed the improvement/ARSN-529/rate_limit_config_model branch from f5bb404 to fd1d771 Compare November 12, 2025 17:42

tmacro force-pushed the improvement/ARSN-529/rate_limit_config_model branch from fd1d771 to 4ba5165 Compare November 12, 2025 18:31

impr(ARSN-529): Add RateLimitConfiguration to BucketInfo

7de5056

tmacro force-pushed the improvement/ARSN-529/rate_limit_config_model branch from 4ba5165 to 7de5056 Compare November 12, 2025 18:39

bert-e merged commit 7de5056 into development/8.2 Nov 14, 2025
7 checks passed

bert-e deleted the improvement/ARSN-529/rate_limit_config_model branch November 14, 2025 16:12

impr(ARSN-529): Add RateLimitConfiguration to BucketInfo #2568

impr(ARSN-529): Add RateLimitConfiguration to BucketInfo #2568

Uh oh!

Conversation

tmacro commented Nov 5, 2025

Uh oh!

bert-e commented Nov 5, 2025

Hello tmacro,

Uh oh!

bert-e commented Nov 5, 2025

Incorrect fix version

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anurag4DSB commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anurag4DSB commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Nov 6, 2025

Request integration branches

Uh oh!

tmacro commented Nov 6, 2025

Uh oh!

bert-e commented Nov 6, 2025

Integration data created

Uh oh!

bert-e commented Nov 6, 2025

Waiting for approval

Uh oh!

anurag4DSB Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

anurag4DSB Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

anurag4DSB Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anurag4DSB Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

bert-e commented Nov 12, 2025

History mismatch

Uh oh!

tmacro commented Nov 12, 2025

Uh oh!

bert-e commented Nov 12, 2025

Reset complete

Uh oh!

bert-e commented Nov 12, 2025

Integration data created

Uh oh!

bert-e commented Nov 12, 2025

Waiting for approval

Uh oh!

bert-e commented Nov 12, 2025

History mismatch

Uh oh!

tmacro commented Nov 12, 2025

Uh oh!

bert-e commented Nov 12, 2025

Reset complete

Uh oh!

bert-e commented Nov 12, 2025

Integration data created

Uh oh!

bert-e commented Nov 12, 2025

Waiting for approval

Uh oh!

bert-e commented Nov 12, 2025

History mismatch

Uh oh!

tmacro commented Nov 12, 2025

Uh oh!

bert-e commented Nov 12, 2025

codecov bot commented Nov 5, 2025 •

edited

Loading

anurag4DSB commented Nov 5, 2025 •

edited

Loading

anurag4DSB commented Nov 5, 2025 •

edited

Loading

anurag4DSB Nov 8, 2025 •

edited

Loading