-
Notifications
You must be signed in to change notification settings - Fork 20
impr(ARSN-534): Fix website redirect for path style buckets #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development/8.2
Are you sure you want to change the base?
Conversation
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
BourgoisMickael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like path style was supposed to be deprecated but they kept it in the end, maybe that's why we did not implement it directly.
Update (September 23, 2020) – To make sure that customers have the time that they need to transition to virtual-hosted–style URLs, we have decided to delay the deprecation of path-style URLs. For more information, see Amazon S3 Path Deprecation Plan – The Rest of the Story in the AWS News Blog.
Can we have as well some functional tests as well that can be run on aws directly ?
acf17d2 to
91eb289
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2567 +/- ##
================================================
Coverage 71.17% 71.18%
================================================
Files 221 221
Lines 17802 17804 +2
Branches 3677 3677
================================================
+ Hits 12671 12673 +2
Misses 5127 5127
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d70918 to
cb4d6a2
Compare
No description provided.