Skip to content

Conversation

@tmacro
Copy link
Contributor

@tmacro tmacro commented Oct 31, 2025

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2025

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2025

Incorrect fix version

The Fix Version/s in issue ARSN-534 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.37

  • 8.3.0

Please check the Fix Version/s of ARSN-534, or the target
branch of this pull request.

Copy link
Contributor

@BourgoisMickael BourgoisMickael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like path style was supposed to be deprecated but they kept it in the end, maybe that's why we did not implement it directly.

Update (September 23, 2020) – To make sure that customers have the time that they need to transition to virtual-hosted–style URLs, we have decided to delay the deprecation of path-style URLs. For more information, see Amazon S3 Path Deprecation Plan – The Rest of the Story in the AWS News Blog.

Can we have as well some functional tests as well that can be run on aws directly ?

@francoisferrand francoisferrand changed the title impr(ARSN-524): Fix website redirect for path style buckets impr(ARSN-534): Fix website redirect for path style buckets Nov 3, 2025
@tmacro tmacro force-pushed the bugfix/ARSN-534/fix_path_style_redirect branch from acf17d2 to 91eb289 Compare November 3, 2025 17:15
@scality scality deleted a comment from bert-e Nov 3, 2025
@bert-e
Copy link
Contributor

bert-e commented Nov 3, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.18%. Comparing base (d92702e) to head (cb4d6a2).
⚠️ Report is 8 commits behind head on development/8.2.

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.2    #2567   +/-   ##
================================================
  Coverage            71.17%   71.18%           
================================================
  Files                  221      221           
  Lines                17802    17804    +2     
  Branches              3677     3677           
================================================
+ Hits                 12671    12673    +2     
  Misses                5127     5127           
  Partials                 4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmacro tmacro force-pushed the bugfix/ARSN-534/fix_path_style_redirect branch from 7d70918 to cb4d6a2 Compare November 4, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants