Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bumpy-bats-go.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

add per page dropdown target portal
3 changes: 3 additions & 0 deletions packages/ui/src/components/Pagination/PerPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ type PerPageProps = {
numberOfItemsText?: string
page: number
numberOfItems: number
portalTarget?: HTMLElement
}

export const PerPage = ({
Expand All @@ -42,6 +43,7 @@ export const PerPage = ({
numberOfItemsText,
page,
numberOfItems,
portalTarget,
}: PerPageProps) => {
const handleChange = (value: string) => {
const intValue = Number.parseInt(value, 10)
Expand All @@ -58,6 +60,7 @@ export const PerPage = ({
name="select-items-per-page"
onChange={handleChange}
options={optionsItemsPerPage}
portalTarget={portalTarget}
size="small"
style={{
width: 'fit-content',
Expand Down
7 changes: 7 additions & 0 deletions packages/ui/src/components/Pagination/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,18 @@ type PaginationProps = {
* Number of items in the list
*/
numberOfItems: number
/**
* Defines the target element for the perPage dropdown menu
*/
perPagePortalTarget?: HTMLElement
}
| {
perPage?: never
onChangePerPage?: never
perPageText?: never
numberOfItemsText?: never
numberOfItems?: never
perPagePortalTarget?: never
}
)

Expand All @@ -78,6 +83,7 @@ export const Pagination = ({
perPageText,
numberOfItemsText,
numberOfItems,
perPagePortalTarget,
'data-testid': dataTestId,
style,
}: PaginationProps) => {
Expand Down Expand Up @@ -108,6 +114,7 @@ export const Pagination = ({
page={page}
perPage={perPageComputed}
perPageText={perPageText}
portalTarget={perPagePortalTarget}
setPerPage={setPerPage}
/>
) : null}
Expand Down
Loading