Skip to content

fix(instance): display sbs volumes' size in instance image list details #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mia-Cross
Copy link
Contributor

The command scw instance image list now fetches volume information from the SBS API to display the correct size of the underlying snapshots.

@Mia-Cross Mia-Cross self-assigned this May 27, 2025
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues labels May 27, 2025
@Mia-Cross Mia-Cross force-pushed the instance_image_list_display_sbs_volume_sizes branch from a7b5799 to 2a38627 Compare May 27, 2025 20:15
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.67%. Comparing base (5bf53e0) to head (888c0c3).
Report is 652 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_image.go 71.42% 4 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (888c0c3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (888c0c3)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4766       +/-   ##
===========================================
- Coverage   75.45%   54.67%   -20.78%     
===========================================
  Files         202      315      +113     
  Lines       44323    80629    +36306     
===========================================
+ Hits        33444    44087    +10643     
- Misses       9653    35135    +25482     
- Partials     1226     1407      +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review May 27, 2025 20:25
@Mia-Cross Mia-Cross requested a review from a team as a code owner May 27, 2025 20:25
…ails
@Mia-Cross Mia-Cross force-pushed the instance_image_list_display_sbs_volume_sizes branch from 4ac6d23 to 68d5977 Compare June 3, 2025 15:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@remyleone remyleone added this pull request to the merge queue Jun 4, 2025
Merged via the queue into scaleway:master with commit 10d8adc Jun 4, 2025
14 checks passed
@Mia-Cross Mia-Cross deleted the instance_image_list_display_sbs_volume_sizes branch June 4, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants