This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
fix: type import broken, fixes #133 #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 779d408 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#102 Bundle Size — 114.45KiB (0%).Bundle metrics
|
| Current #102 |
Baseline #98 |
|
|---|---|---|
 Initial JS |
114.45KiB |
114.45KiB |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
45 |
45 |
| Assets |
45 |
45 |
| Modules |
45 |
45 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
0 |
0 |
| Duplicate Packages |
0 |
0 |
Bundle analysis report Branch fix/type-import-broken Project dashboard
|
There are some weird issues with the |
hanspagel
added a commit
that referenced
this pull request
Jun 21, 2024
* chore: update build setup * refactor: move files around * chore: remove src/ folder from dist/ folder structure * fix: can’t find test file * chore: show output size * chore: add terser to minify the build * chore: don’t publish the webpack stats output * chore: rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don’t know why the type import seems to work in the demo and in
scalar/scalar, but the path is just wrong.I just tried to find a way to catch this in CI, which seemed straight-forward, but it’s all just passing.
Anyway, here is the quick fix. I’ll find a solution to prevent this in the future.