Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

fix: max call stack exceeded #116

Merged
merged 16 commits into from
Jun 6, 2024
Merged

fix: max call stack exceeded #116

merged 16 commits into from
Jun 6, 2024

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented Jun 3, 2024

I’ve seen max call stack exceeded errors for a few specifications. This PR fixes it, but it’s a terrible hack.

The problem is, that for the pipeline to work as expected, all functions need to return a FileSystem. But the deference function returns more (errors, OpenAPI version …). From now on, all relevant functions return an object.

Let me think about a better solution to streamline the return of the functions.

Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: f16fa71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scalar/openapi-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

relativeci bot commented Jun 3, 2024

#75 Bundle Size — 114.71KiB (+0.5%).

f16fa71(current) vs c9dd499 main#73(baseline)

Bundle metrics  Change 5 changes Regression 1 regression
                 Current
#75
     Baseline
#73
Regression  Initial JS 114.71KiB(+0.5%) 114.14KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 6.25% 0.91%
Change  Chunks 45(+2.27%) 44
Change  Assets 45(+2.27%) 44
Change  Modules 45(+2.27%) 44
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#75
     Baseline
#73
Regression  JS 114.71KiB (+0.5%) 114.14KiB

Bundle analysis reportBranch fix/max-call-stack-errorProject dashboard

Copy link

cloudflare-workers-and-pages bot commented Jun 5, 2024

Deploying openapi-parser with  Cloudflare Pages  Cloudflare Pages

Latest commit: f16fa71
Status: ✅  Deploy successful!
Preview URL: https://b7b55129.openapi-parser.pages.dev
Branch Preview URL: https://fix-max-call-stack-error.openapi-parser.pages.dev

View logs

@hanspagel hanspagel marked this pull request as ready for review June 5, 2024 14:37
@hanspagel hanspagel requested a review from marclave June 5, 2024 14:37
@hanspagel hanspagel enabled auto-merge (squash) June 6, 2024 10:36
@hanspagel hanspagel disabled auto-merge June 6, 2024 10:37
@hanspagel hanspagel merged commit 61252ab into main Jun 6, 2024
7 checks passed
@hanspagel hanspagel deleted the fix/max-call-stack-error branch June 6, 2024 10:37
@hanspagel hanspagel mentioned this pull request Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant