fix: ignore responses from other clients #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change a while back that makes the buf request go to all the attached clients. For Scala normally this isn't an issue at all, but if you're using co-pilot which is also a client in this situation it will fire metals requests to it which you don't want. We then throw an error in that situation while the command still worked. This is confusing for users, so this should fix the issue by filtering out the responses that don't match metals.
|
fixes #664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change a while back that makes the buf request go to all the
attached clients. For Scala normally this isn't an issue at all, but if
you're using co-pilot which is also a client in this situation it will
fire metals requests to it which you don't want. We then throw an error
in that situation while the command still worked. This is confusing for
users, so this should fix the issue by filtering out the responses that
don't match metals.