Do not instantiate DataVaultService in webknossos module.

[fm3]

This service depends on datastore config + datastore rpc client. It cannot be instantiated in the webknossos module. It is also not needed there.

Follow-up fix for #8980

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed the DataVaultService import and its eager singleton binding from WebknossosModule.scala. This eliminates compile-time dependency tracking and runtime eager initialization for DataVaultService while preserving all other module bindings.

Changes

Cohort / File(s)	Change Summary
Dependency Removal app/WebknossosModule.scala	Removed DataVaultService import statement and removed its eager singleton binding from the module configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Verify that DataVaultService is not referenced elsewhere in the codebase that would break with its removal from eager bindings
• Confirm no other modules or components depend on this eager initialization behavior
• Check if this change aligns with intended lazy-loading or deferred initialization strategy

Poem

🐰 With a hop and a skip, we cleared the way,
Unbind the vault, let dependencies play!
Imports removed, the module now light,
One less eager friend starting at night. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Do not instantiate DataVaultService in webknossos module" directly and accurately describes the main change in the changeset. The raw summary confirms that DataVaultService import and its eager singleton binding have been removed from WebknossosModule.scala. The title is concise, specific, and clearly communicates the primary intent of the change without ambiguity or noise.
Description Check	✅ Passed	The pull request description is clearly related to the changeset. The author explains that DataVaultService depends on datastore config and datastore RPC client, making it impossible to instantiate in the webknossos module and unnecessary there. This reasoning directly aligns with the code changes, which removed the DataVaultService import and its eager singleton binding from WebknossosModule.scala. The description provides meaningful context about the motivation for the removal and references a follow-up to issue #8980, demonstrating this is part of a larger initiative.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wk-module-no-datavault-service

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}