Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add existing tree to annotation #1201

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix add existing tree to annotation #1201

wants to merge 10 commits into from

Conversation

MatthisCl
Copy link
Contributor

@MatthisCl MatthisCl commented Oct 11, 2024 •
edited by markbader
Loading

Description:

  • When trying to deepcopy a group, hashfunction is needed before initialization. This leads to an error as self._id is not set before initialization. One could change the hashfunction to not be dependent on the id or change the hashfunction

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

@markbader markbader self-assigned this Oct 29, 2024
@markbader markbader changed the title add test and change hash function Fix add existing tree to annotation Oct 29, 2024
@markbader markbader marked this pull request as ready for review October 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markbader markbader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot add existing tree to new annotation
2 participants
@MatthisCl @markbader