Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close backticks #280

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Auto-close backticks #280

merged 1 commit into from
Jan 10, 2025

Conversation

harpocrates
Copy link
Contributor

@harpocrates harpocrates commented Jan 10, 2025

Typing a backtick now automatically adds a closing backtick as well. Also possible to quickly add backticks around idents by selecting and typing backtick.

Fixes #279

Typing a backtick now automatically adds a closing backtick as well.
Also possible to quickly add add backticks are ident by selecting and
typing backtick.

Fixes scala#279
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@harpocrates
Copy link
Contributor Author

I'm confused by the CLA failure. I signed the CLA a while back for some scalac change and even https://www.lightbend.com/contribute/cla/scala/check/harpocrates reports signed: true. Is there anything I'm supposed to do that I missed?

@tgodzik
Copy link
Contributor

tgodzik commented Jan 10, 2025

I think it's an issue with a domain change. I think we're fine

@tgodzik tgodzik merged commit a88f1ae into scala:main Jan 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backticks should be auto-closed
2 participants