Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight ''' as single quote character literal #261

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Highlight ''' as single quote character literal #261

merged 1 commit into from
Oct 18, 2023

Conversation

nicolasstucki
Copy link
Contributor

Fixes #260

@som-snytt
Copy link

I would highlight it as an error.

tgodzik
tgodzik approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicolasstucki
Copy link
Contributor Author

I would highlight it as an error.

The compiler interpreta it correctly and suggest the escaped version. It is not technically wrong to have this code.

@nicolasstucki nicolasstucki merged commit bdd18ee into scala:main Oct 18, 2023
2 checks passed
@nicolasstucki nicolasstucki deleted the fix-260 branch October 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect syntax highlighting with single quotes
3 participants
@nicolasstucki @som-snytt @tgodzik