Treat local mutable vars as capabilities #24815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move operations a bit higher up the callchain and allow for more modifications what is allowed.
When we have
var x: A^{c} = ...
where `x` is a local variable then when dereferencing `x` we also need to charge `c`.
This was forgotten before. For fields it's not a problem since `c` would already have been
charged for the prefix `p` in `p.x`.
An alternative would be to consider mutable variables to have boxed types. Then the same
capture set would be charged on unboxing.
odersky
force-pushed
the
local-mutable-vars
branch
from
cd61aff to
feb9b90
Compare
bracevac
approved these changes
Dec 22, 2025
| case self: CoreCapability => self.isTrackableRef | ||
| case _ => true | ||
|
|
||
| /** Under separatiion checking: Is this a mutable var owned by a term that is |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Under separatiion checking: Is this a mutable var owned by a term that is | |
| /** Under separation checking: Is this a mutable var owned by a term that is |
| var r: Int = 0 | ||
| (() => r, (x: Int) => r = x) | ||
|
|
||
| class Struct: |
Contributor
There was a problem hiding this comment.
The asymmetry between pairs and such a custom class is jarring.
I'm wondering if we could have a less boilerplate-y way of achieving the Struct case with standard pairs? Could we have a scoped delimiter that
says "We allow construction of data with shared components here"?
def foo() =
val r = Ref()
shared:
(() => r.get, (x: Int) => r.set(x)) // ok, nowMaking sure that the cap of the pair object subsumes the component caps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under separation checking: A mutable var owned by a term that is not annotated with @untrackedCaptures gives rise to a Mutable capability. Since a mutable variable is not trackable, we do this by adding a varMirror symbol to the variable which represents the capability.