Add accessible check for import usage #23348
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/23347-import-private-alias
branch
2 times, most recently
from
fc0efa7 to
1ecd165
Compare
som-snytt
force-pushed
the
issue/23347-import-private-alias
branch
from
1ecd165 to
c76b42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23347
The code for deciding whether a selector is used to import a symbol was missing a check for accessibility (importability).
3.6.4 doesn't warn, so it would be nice to know why it excludes the member. The algorithm is different but the code for choosing import selectors is similar. 3.7.0 also doesn't warn, but no change stands out as a culprit. Possibly the selector was spuriously excluded (by result caching in 3.7.0).