Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2906: Misleading warning when two deps reference the same val version #2907

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexklibisz
Copy link
Contributor

PR reproducing #2906

I'm open to advice on how to:

  1. Make test assertions about logs. The way I did it is very hacked together.
  2. Fix the underlying issue. Maybe it's also an opportunity for an optimization? If an update was already applied, maybe we can avoid trying to apply it again?

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 89.59% // Head: 89.59% // No change to project coverage 👍

Coverage data is based on head (0ab2a67) compared to base (96303ba).
Patch has no changes to coverable lines.

❗ Current head 0ab2a67 differs from pull request most recent head 5bb0ecc. Consider uploading reports for the commit 5bb0ecc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2907   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files         158      158           
  Lines        3036     3036           
  Branches      197      197           
=======================================
  Hits         2720     2720           
  Misses        316      316           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant