Check files under .github updated

[exoego]

Closes #2608

[codecov]

Codecov Report

Base: 80.58% // Head: 80.58% // No change to project coverage 👍

Coverage data is based on head (b9d4718) compared to base (b9d4718).
Patch has no changes to coverable lines.

❗ Current head b9d4718 differs from pull request most recent head 9d11154. Consider uploading reports for the commit 9d11154 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files         149      149           
  Lines        2849     2849           
  Branches      198      198           
=======================================
  Hits         2296     2296           
  Misses        553      553           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[fthomas]

In the last commit I used the same artifactIds as in the play-json PR and also added the file where Scala Steward did actually update the version. It is failing now as reported in #2608.

[fthomas]

I also tried this case with #2816 but it is also failing there.

[mzuehlke]

I converted the test to a RewriteTest and found that the .github/ folder is not the problem, but the key scala in the ci.yml prevents the update. If I change the key to scala3it works.

The following tests passes:

  test("Files under .github yml should be updated".only) {
    val artifactIds = Nel.of("scala3-compiler".a, "scala3-library".a, "scala3-library_sjs1".a)
    val update = ("org.scala-lang".g % artifactIds % "3.1.3-RC2" %> "3.1.3-RC3").group
    val original = Map(
      "project/Dependencies.scala" -> """val Scala3 = "3.1.3-RC2" """,
      ".github/workflows/ci.yml" -> """scala3: 2.12.15, 2.13.8, 3.1.3-RC2"""
    )
    val expected = Map(
      "project/Dependencies.scala" -> """val Scala3 = "3.1.3-RC3" """,
      ".github/workflows/ci.yml" -> """scala3: 2.12.15, 2.13.8, 3.1.3-RC3"""
    )
    runApplyUpdate(update, original, expected)
  }	

[fthomas]

[...] but the key scala in the ci.yml prevents the update. If I change the key to scala3it works.

I think we can make it work, if we add scala as a search term if one the search terms is scala3. Or we strip trailing digits from all search terms.