Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Scala 3 #6

wants to merge 3 commits into from

Conversation

arashi01
Copy link

  • Update Scala versions.
  • Update sbt, sbt plugins, GitHub Actions.
  • Enable Scala 3 build.

@sjrd
Copy link
Member

sjrd commented Jul 31, 2023

What is the motivation for this PR? As the readme mentions, you probably should not use this library for anything except when talking to scalajs-linker and scalajs-js-envs. Those libraries are built for 2.12 and 2.13 only, by design of how the Scala.js repo is organized. If necessary, they can be used from Scala 3 using cross(CrossVersion.for3Use2_13).

@arashi01
Copy link
Author

@sjrd Mainly so we can move on to publishing scalajs-js-envs for Scala 3 if that is the plan, to get rid of the cross(CrossVersion.for3Use2_13) usages.

@sjrd
Copy link
Member

sjrd commented Jul 31, 2023

The situation is basically the same for scalajs-js-envs: what's the actual issue with for3Use2_13?

I guess if you want scalajs-js-envs on _3, you will also want scalajs-linker. But the latter is very unlikely to get built for _3 in the foreseeable future, due to how scala-js/scala-js is architected; it would create a circular dependency between scala-js/scala-js and lampepfl/dotty, which is not desirable.

From my point of view, it's much easier to keep using for3Use2_13 for this set of core libraries. None of them define any macro nor have they any dependency on any external library, so it's always safe to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants