Fix multi-platform builds with multiple aliases. #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-platform builds append a `-t` argument for each alias to the `dockerBuildOptions`, but the `publishTask` function was ALWAYS iterating over the aliases even if it was a multi-platform build. The consequence was attempts to buildx and push the tags multiple times. In some environments this leads to build failures because you can't push the same tag twice. This change simply does not iterate over the aliases for multiplatform builds.
|
Hi @zarthross, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Akka Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
The CLA signer process is broken... I cannot sign it... not sure what ya'll want to do about it. |
|
This is basically a 1 line fix, i do not care about the CLA, i do not care about copy right to the code, just wanted others to have the fix..... |
|
The CLA bot has an insecure http: URL... This link should work: https://www.lightbend.com/contribute/cla |
muuki88
approved these changes
Nov 25, 2024
muuki88
reviewed
Nov 25, 2024
|
We'll get rid of the CLA after #1653 |
|
Thanks a lot 🙏 |
|
@muuki88 Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-platform builds append a
-targument for each alias to thedockerBuildOptions, but thepublishTaskfunction was ALWAYS iterating over the aliases even if it was a multi-platform build.sbt-native-packager/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala
Lines 157 to 159 in 7c68859
The consequence was attempts to buildx and push the tags multiple times. In some environments this leads to build failures because you can't push the same tag twice.
This change simply does not iterate over the aliases for multiplatform builds.
Note: using
dockerUpdateLatest := truecounts as having multiple aliases, which is how I encountered this bug.