refactor: Rewrite unicode arrow #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** The unicode arrow is deprecated. **Solution** This rewrites it to `=>`
eed3si9n
force-pushed
the
wip/unicode-arrow
branch
from
c721008
to
6bd559f
Compare
BillyAutrey
approved these changes
Nov 11, 2024
dwickern
reviewed
Nov 11, 2024
| } | ||
| val expectedImage = (JDKPackager / target).value / "bundles" / (name.value + extension) | ||
| println(s"Checking for '${expectedImage.getAbsolutePath}'") | ||
| assert(expectedImage.exists, s"Expected image file to be found at '$expectedImage'") | ||
|
|
||
| val files = os match { | ||
| case 'mac ⇒ | ||
| case 'mac => |
There was a problem hiding this comment.
Speaking of deprecated features, I see there are symbol literals in the codebase
dwickern
approved these changes
Nov 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an offshoot from sbt 2.x migration #1647
Problem
The unicode arrow is deprecated.
Solution
This rewrites it to
=>.