Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to slash syntax #1636

Merged
merged 16 commits into from
Oct 13, 2024
Merged

migrate to slash syntax #1636

merged 16 commits into from
Oct 13, 2024

Conversation

jtjeferreira
Copy link
Contributor

In preparation for sbt 2.x, migrate to slash syntax

muuki88
muuki88 previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @jtjeferreira ❤️ ❤️

@muuki88
Copy link
Contributor

muuki88 commented Oct 9, 2024

I think you added slashes in a few places where they aren't correct :D
https://github.com/sbt/sbt-native-packager/actions/runs/11256140432/job/31297541037?pr=1636#step:5:351

@jtjeferreira
Copy link
Contributor Author

I think you added slashes in a few places where they aren't correct :D sbt/sbt-native-packager/actions/runs/11256140432/job/31297541037?pr=1636#step:5:351

I might have added slashes too the wrong places, but I don't see where... I noticied that github actions are now using ubuntu-24 instead of ubuntu-22 like in the 3 weeks ago ubuntu-22.04. I will investigate

@jtjeferreira jtjeferreira mentioned this pull request Oct 9, 2024
Merged
@BillyAutrey BillyAutrey mentioned this pull request Oct 9, 2024
Open
@jtjeferreira
Copy link
Contributor Author

The scripted tests still contain deprecated syntax like universal:packageBin, happy to fix it here or in another PR

@muuki88 muuki88 merged commit 7acfb04 into sbt:master Oct 13, 2024
15 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Oct 13, 2024 •
edited
Loading

Thanks a lot @jtjeferreira for this huge contribution. Especially because it's not fancy stuff, but highly necessary cleanup work 🙏 🙏

Happy to merge another PR with a cleanup in the sbt tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtjeferreira @muuki88