Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerPlugin publishTask: switch --push flag to --output=type=registry #1564

Closed

Conversation

zachdecook
Copy link

--push is shorthand for --output=type=registry (https://docs.docker.com/engine/reference/commandline/buildx_build/#push)

By specifying --output=type=registry, sbt can support when docker is a symlink to podman.

@lightbend-cla-validator
Copy link

Hi @zachdecook,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@zachdecook
Copy link
Author

This is incorrect. (it fixes a symptom of the problem, but podman requires a second command to be run to push it).

Probably it's best fixed by patching podman.

@zachdecook zachdecook closed this Jan 4, 2024
@zachdecook zachdecook deleted the docker-buildx-output-type-registry branch January 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants