Windows bat script improvements #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to support new arguments. It shouldn't change the functionality.
|
Hi @dwickern, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
Parse arguments before verifying the Java installation
dwickern
force-pushed
the
bat-improvements
branch
from
3e59c23
to
a95ddac
Compare
|
Thanks a lot @dwickern . The test failures seem unrelated. I guess GraalVM & Docker need constant maintenance. Thus I merged your change for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some things missing for complete parity with the bash script but this gets us a little closer.
Fixes parsing of
-J-XX:options containing an equal signI'm using the same logic as sbt's own launcher. Unless it starts with
-XX:+or-XX:-, all-XX:options are parsed as two argumentsFixes #1387
Fixes #1090
Note that if you're using the workaround from #1387 by quoting the options in
application.ini, that will no longer work.Implements
-java-homeoptionUsed like
-java-home "C:\Program Files\Eclipse Adoptium\jre-11.0.13.8-hotspot"or-java-home "%APP_HOME%\jre". The argument has higher priority than environment variables.Fixes #1447
Fixes #1070