Merged
Conversation
Member
luciansmith
commented
Mar 10, 2026
- sprintf->snprintf
- Addresses of actual objects are never NULL
- 'this' is never NULL
- Add default cases for ASTNode switch statements.
* sprintf->snprintf * Addresses of actual objects are never NULL * 'this' is never NULL * Add default cases for ASTNode switch statements.
I'm not sure testing calling a function on NULL is a good idea? But it's there, I guess.
fbergmann
approved these changes
Mar 12, 2026
Member
fbergmann
left a comment
There was a problem hiding this comment.
looks good to me though it seems odd, that we have different array lengths in our code base.
and i'd much rather see the use of normal stl instead, like std::to_string rather than snprintf.
and the group thing, since isSetGroup always return true, we really dont need to check for isSetGroup ever.
Member
Author
|
Yeah, I left in the 'isSetGroup' function just in case we changed our implementation in the future. Like, perhaps we'll want to check if anything is non-default in the 'group' object, and only write things out then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.