Allow building zlib and libsbml at the same time.#474
Merged
fbergmann merged 2 commits intodevelopmentfrom Mar 11, 2026
Merged
Conversation
The check_library_exists function breaks my build when building both zlib and libsbml at once. I get the error:
CMake Error at C:/Users/Lucian/Desktop/libroadrunner-deps-backup/build-debug/CMakeFiles/CMakeScratch/TryCompile-m25yy5/CMakeLists.txt:28 (target_link_libraries):
Error evaluating generator expression:
$<TARGET_LINKER_FILE:zlibstatic>
No target "zlibstatic"
If I then hit compile again, it works! But the first time, it fails, and it needs to work the first time for my github action.
This problem was obfuscated by it previously trying to assign the result to LIBZ_CMAKE_PATH, which already existed, so it... broke the check? Maybe? Anyway.
I don't think we need to check that the library exists anyway. We don't do it for any of the XML libraries, and only do it for BZip. Which would probably also break my build, but I'm not including bzip in my build at all.
By default no test for symbols from the library will be made, but if `ZLIB_CHECK_FOR_SYMBOLS` is defined the library will be checked.
fbergmann
approved these changes
Mar 11, 2026
Member
fbergmann
left a comment
fbergmann
left a comment
There was a problem hiding this comment.
@luciansmith rather than leave the code there commented out i just disabled it, leaving people to enable it if they had a need.
This should solve your original issue.
Otherwise its fine to just remove the statements altogether, but then the line changing the path to the zlib library should also be changed. Oh and the error message was just wrong and did not actually print the name of the zlib library.
Member
Author
|
Looks good to me! Is there something more you wanted someone to do, cf "changing the path to the zlib library should also be changed"? Or is this ready to merge? |
Member
|
@luciansmith thats all included in my change so its ready to merge and i will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check_library_exists function breaks my build when building both zlib and libsbml at once. I get the error:
CMake Error at C:/Users/Lucian/Desktop/libroadrunner-deps-backup/build-debug/CMakeFiles/CMakeScratch/TryCompile-m25yy5/CMakeLists.txt:28 (target_link_libraries):
Error evaluating generator expression:
No target "zlibstatic"
If I then hit compile again, it works! But the first time, it fails, and it needs to work the first time for my github action.
This problem was obfuscated by it previously trying to assign the result to LIBZ_CMAKE_PATH, which already existed, so it... broke the check? Maybe? Anyway.
I don't think we need to check that the library exists anyway. We don't do it for any of the XML libraries, and only do it for BZip. Which would probably also break my build, but I'm not including bzip in my build at all.