-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ofti time warning #355
Ofti time warning #355
Conversation
@michaelkmpoon once you accept collaborator request I'll ask you to review the (minor) changes to this PR, then I'll pull it to the v3 branch. |
@sblunt the minor changes looks good to me! Not sure why some of the tests failed though |
Sweet! Tests failing is my fault I think. I've just restarted them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Minor changes to #345. Ready to pull in with Michael's approval (and tests passing)