Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reward dataset with TemplateRewardBenchDataset #96

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Update reward dataset with TemplateRewardBenchDataset #96

merged 2 commits into from
Nov 29, 2024

Conversation

ryokan0123
Copy link
Contributor

Update the reward bench datasets with a base class TemplateRewardBenchDataset.
This enable to share logics between HFRewardBenchDataset and JsonlRewardBenchDataset.

@ryokan0123 ryokan0123 requested a review from kajyuuen November 29, 2024 03:05
@ryokan0123 ryokan0123 force-pushed the update_reward_dataset branch from 0442fe9 to 6d8910c Compare November 29, 2024 03:09
@ryokan0123 ryokan0123 force-pushed the update_reward_dataset branch from 6d8910c to 550520b Compare November 29, 2024 03:12
kajyuuen
kajyuuen approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@kajyuuen kajyuuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@ryokan0123 ryokan0123 merged commit e523d82 into main Nov 29, 2024
9 checks passed
@ryokan0123 ryokan0123 deleted the update_reward_dataset branch November 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajyuuen kajyuuen kajyuuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryokan0123 @kajyuuen