Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Feature/save config #85

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[FIX] Feature/save config #85

merged 3 commits into from
Nov 22, 2024

Conversation

akiFQC
Copy link
Collaborator

@akiFQC akiFQC commented Nov 22, 2024

関連する Issue / PR

  • 実験の設定ファイルを保存する前に、save_dir が作成されていない場合に、directory does not exist というエラーが発生する。

PR をマージした後の挙動の変化

  • バグの修正
  • test caseの追加

挙動の変更を達成するために行ったこと

  • 実験の設定ファイルを保存する前にsave_dirがなければディレクトリを作成するという処理を追加
  • テストケースを追加

動作確認

  • テストが通ることを確認した
  • マージ先がdevブランチであることを確認した

@akiFQC akiFQC requested a review from lsz05 November 22, 2024 01:51
@akiFQC akiFQC changed the base branch from main to dev November 22, 2024 01:51
Copy link
Collaborator

@lsz05 lsz05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

@lsz05 lsz05 merged commit b4d0df2 into dev Nov 22, 2024
3 checks passed
@lsz05 lsz05 mentioned this pull request Dec 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants