[Feature] Allow setting encode kwargs in SentenceBert embedder #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
全体的にLGTMですが、kwarfgsに検索するdoc stringを足していただけると良いかと思いました |
akiFQC
approved these changes
Nov 27, 2024
| @@ -43,6 +43,7 @@ def _batch_encode_and_save_on_disk( | |||
| prefix: str | None = None, | |||
| batch_size: int = 262144, | |||
| dtype: str = "float32", | |||
| **kwargs, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連する Issue / PR
#77
PR をマージした後の挙動の変化
encode時に独自な引数が必要な場合を対応
挙動の変更を達成するために行ったこと
encode_kwargsを追加encode_kwargs引数対応動作確認