Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] rerankingでのformat不具合 #45

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[Fix] rerankingでのformat不具合 #45

merged 1 commit into from
Jul 30, 2024

Conversation

lsz05
Copy link
Collaborator

@lsz05 lsz05 commented Jul 26, 2024

関連する Issue / PR

#44

PR をマージした後の挙動の変化

#44 の不具合が解決

挙動の変更を達成するために行ったこと

キャッシュから読み込んだembedding vectorsがnp.mmapの可能性があることが不具合の原因と判明し,Tensorに変換することで解消

動作確認

  • テストが通ることを確認した
  • マージ先がdevブランチであることを確認した

@lsz05 lsz05 marked this pull request as ready for review July 26, 2024 11:31
@akiFQC
Copy link
Collaborator

akiFQC commented Jul 30, 2024

LGTM

@akiFQC
Copy link
Collaborator

akiFQC commented Jul 30, 2024

マージいただいてOKです。

@lsz05 lsz05 merged commit 161d40a into dev Jul 30, 2024
3 checks passed
@lsz05 lsz05 mentioned this pull request Aug 19, 2024
1 task
@lsz05 lsz05 deleted the fix/reranking_tensor branch August 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants