Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update embedding networks notebook #1297

Merged
merged 1 commit into from
Oct 19, 2024
Merged

docs: update embedding networks notebook #1297

merged 1 commit into from
Oct 19, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

What does this implement/fix? Explain your changes

Commit 109d7e9 renamed the embedding networks notebook. This PR adjusts sources to changes.

Does this close any currently open issues?

Fixes # (issue)

Any relevant code examples, logs, error output, etc?

...

Any other comments?

...

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read and understood the contribution
    guidelines
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have reported how long the new tests run and potentially marked them
    with pytest.mark.slow.
  • New and existing unit tests pass locally with my changes
  • I performed linting and formatting as described in the contribution
    guidelines
  • There are no conflicts with the main branch

For the reviewer:

  • I have reviewed every file
  • All comments have been addressed.

Signed-off-by: Emmanuel Ferdman <[email protected]>
@michaeldeistler
Copy link
Contributor

Thanks a lot for the pointer and the fix!

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (fd30537) to head (1465b62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1297       +/-   ##
===========================================
- Coverage   89.30%   78.36%   -10.94%     
===========================================
  Files         119      119               
  Lines        8721     8728        +7     
===========================================
- Hits         7788     6840      -948     
- Misses        933     1888      +955     
Flag Coverage Δ
unittests 78.36% <ø> (-10.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing this!

@janfb janfb merged commit 3d5cb24 into sbi-dev:main Oct 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants