Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joss paper draft #1294

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

joss paper draft #1294

wants to merge 19 commits into from

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Oct 15, 2024

  • add paper draft
  • add action to test-build from markdown.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (428fc93) to head (1770e12).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1294       +/-   ##
===========================================
- Coverage   89.30%   78.36%   -10.94%     
===========================================
  Files         119      119               
  Lines        8721     8728        +7     
===========================================
- Hits         7788     6840      -948     
- Misses        933     1888      +955     
Flag Coverage Δ
unittests 78.36% <ø> (-10.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments and nitpicks.
This looks very nice! Thanks for putting this together.

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants