fixup for failing conditional sampling tests #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelgloeckler
approved these changes
Oct 4, 2024
tests/linearGaussian_fmpe_test.py
Outdated
| @@ -287,7 +287,7 @@ def simulator(theta): | |||
| # Evaluate the conditional density be drawing samples and smoothing with a Gaussian | |||
| # kde. | |||
| potential_fn, theta_transform = posterior_estimator_based_potential( | |||
| posterior_estimator, prior=prior | |||
| posterior_estimator, prior=prior, x_o=None | |||
There was a problem hiding this comment.
Has x_o recently made a required positional argument?
I was just wondering as the previous code would have just raised an error.
There was a problem hiding this comment.
It has always been a required argument. And yes, the test failed because the error got raised. See #1276 for how the bug happened.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
===========================================
- Coverage 89.24% 78.36% -10.88%
===========================================
Files 119 119
Lines 8695 8728 +33
===========================================
- Hits 7760 6840 -920
- Misses 935 1888 +953
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken tests to prepare for release.
#1276 caused issues in conditional sampling tests
#1279 caused issues with LC2ST accuracy tests