Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slow tests. #1209

Merged
merged 3 commits into from
Aug 2, 2024
Merged

fix: slow tests. #1209

merged 3 commits into from
Aug 2, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jul 30, 2024

slow tests for tsnpe sir need a bit more samples. Probably because the random state changed because of removing simulate_for_sbi.

  • added a couple of other small changes to make slow tests pass again.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (ba19688) to head (fd69fe7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   84.55%   84.35%   -0.21%     
==========================================
  Files          96       96              
  Lines        7603     7702      +99     
==========================================
+ Hits         6429     6497      +68     
- Misses       1174     1205      +31     
Flag Coverage Δ
unittests 84.35% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@janfb janfb changed the title fix: tsnpe sir test fix: slow tests. Aug 2, 2024
@janfb
Copy link
Contributor Author

janfb commented Aug 2, 2024

CD is passing now 🎉

@janfb janfb requested a review from michaeldeistler August 2, 2024 08:27
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@janfb janfb merged commit 0bdb9c5 into main Aug 2, 2024
7 checks passed
@janfb janfb deleted the fix-tests branch August 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants