Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helpers from tests, skip GPU tests. #1105

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Remove helpers from tests, skip GPU tests. #1105

merged 2 commits into from
Mar 25, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Mar 22, 2024

What does this implement/fix? Explain your changes

  • remove helper functions from tests when they are not needed
  • add pytest hook to skip GPU tests when no devices are available: running pytest tests/ locally without GPU will skip all gpu marked tests, i.e., act like pytest -m "not gpu" tests/

Does this close any currently open issues?

Fixes #1093 #1098

@janfb janfb changed the title Refactor tests Remove helpers from tests, skip GPU tests. Mar 22, 2024
@janfb janfb requested a review from zinaStef March 22, 2024 14:21
@zinaStef zinaStef merged commit 32e365d into main Mar 25, 2024
3 checks passed
@janfb janfb deleted the refactor-tests branch May 7, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinaStef zinaStef zinaStef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU tests fail when CUDA is not available, instead of being skipped
2 participants
@janfb @zinaStef