update notebook, bugfixes

sbi-dev · Dec 12, 2024 · 074efa0 · 074efa0
1 parent b2fe636
commit 074efa0
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 99 deletions.
diff --git a/sbi/inference/potentials/likelihood_based_potential.py b/sbi/inference/potentials/likelihood_based_potential.py
@@ -134,12 +134,12 @@ def conditioned_potential(
             theta: Tensor, x_o: Optional[Tensor] = None, track_gradients: bool = True
         ) -> Tensor:
             assert (
-                len(dims_to_sample) == theta.shape[1] - condition.shape[1]
+                len(dims_to_sample) == theta.shape[1]
             ), "dims_to_sample must match the number of parameters to sample."
             theta_without_condition = theta[:, dims_to_sample]
 
             return _log_likelihood_with_iid_condition(
-                x=x_o or self.x_o,
+                x=x_o if x_o is not None else self.x_o,
                 theta_without_condition=theta_without_condition,
                 condition=condition,
                 estimator=self.likelihood_estimator,