Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare standalone usage of buttons #3326

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Dec 23, 2024

We want to provide mixins (classes?) for the sbb-button to allow place it on a native <button> element. To achieve this goal, this PR refactors the styles of the button, which is a prerequisite for #3075

Open topics:

  • forced Colors negative has glitch:
    image
  • testing on small resolutions screens
  • Do we accept slightly less smooth border radius?

@github-actions github-actions bot temporarily deployed to pr3326 December 23, 2024 14:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 23, 2024 14:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3326 December 23, 2024 18:52 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 23, 2024 18:53 Inactive
@github-actions github-actions bot temporarily deployed to pr3326 December 24, 2024 09:16 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 24, 2024 09:17 Inactive
@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Dec 24, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request pr: visual review required preview-available target: 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant