feat: add Angular wrapper #3267

DavideMininni-Fincons · 2024-12-02T11:05:32Z

No description provided.

# Conflicts: # package.json # yarn.lock

This reverts commit e91d964.

# Conflicts: # package.json # src/elements/file-selector/file-selector.ts # src/elements/radio-button/radio-button-group/radio-button-group.ts # yarn.lock

jeripeierSBB

Stunning work. Only very partial review

jeripeierSBB · 2024-12-03T08:22:41Z

package.json

@@ -71,12 +74,23 @@
    "lit": "3.2.1"
  },
  "devDependencies": {
+    "@angular-devkit/build-angular": "^18.2.3",


I suggest to go to Angular 19 for all angular deps

Suggested change

"@angular-devkit/build-angular": "^18.2.3",

"@angular-devkit/build-angular": "18.2.3",

jeripeierSBB · 2024-12-03T08:23:19Z

package.json

    "@commitlint/cli": "19.6.0",
    "@commitlint/config-conventional": "19.6.0",
    "@custom-elements-manifest/analyzer": "0.10.3",
    "@custom-elements-manifest/to-markdown": "0.1.0",
-    "@eslint/eslintrc": "3.2.0",
+    "@eslint/eslintrc": "3.1.0",


downgrade needed?

jeripeierSBB · 2024-12-03T08:24:36Z

package.json

@@ -125,13 +139,15 @@
    "lint-staged": "15.2.10",
    "lit-analyzer": "2.0.3",
    "madge": "8.0.0",
-    "npm-run-all2": "7.0.1",
+    "ng-packagr": "18.2.1",
+    "npm-run-all2": "7.0.0",


downgrade needed?

jeripeierSBB · 2024-12-03T08:25:26Z

package.json

@@ -145,7 +161,8 @@
    "typescript-eslint": "8.16.0",
    "urlpattern-polyfill": "10.0.0",
    "vite": "5.4.11",
-    "vite-plugin-dts": "4.3.0"
+    "vite-plugin-dts": "4.3.0",
+    "zone.js": "~0.14.10"


Shouldn't we try to avoid zone.js at all?

jeripeierSBB · 2024-12-03T08:26:43Z

tsconfig.json

@@ -20,6 +20,8 @@
      "@sbb-esta/lyne-elements/*": ["src/elements/*"],
      "@sbb-esta/lyne-elements-experimental": ["src/elements-experimental"],
      "@sbb-esta/lyne-elements-experimental/*": ["src/elements-experimental/*"],
+      "@sbb-esta/lyne-angular": ["src/angular"],
+      "@sbb-esta/lyne-angular/*": ["src/angular/*"],


angular experimental entries needed?

tools/vite/dts.ts

src/elements-experimental/timetable-row/timetable-row.ts

jeripeierSBB · 2024-12-03T08:39:07Z

src/angular/core/mixins/constructor.ts

@@ -0,0 +1,10 @@
+// TODO check if makes sense or they are just duplicated and possibily remove.


I tried to standardize todo / fixmes like TODO:

Suggested change

// TODO check if makes sense or they are just duplicated and possibily remove.

// TODO: check if makes sense or they are just duplicated and can possibily be removed.

# Conflicts: # package.json # yarn.lock

tools/eslint/angular-generator-rule.ts

kyubisation

Initial impression is positive. Amazing work! 😃
I guess to test it, we need to generate the code.

DavideMininni-Fincons · 2024-12-04T07:58:36Z

Initial impression is positive. Amazing work! 😃 I guess to test it, we need to generate the code.

I started yesterday, found some little detail to fix; i'll hope to finish it tomorrow

…ial)

# Conflicts: # package.json # yarn.lock

tools/eslint/angular-generator-rule.ts

+                  // FIXME add import from esta core/attribute-transform
+                  if (member.type.getText() === 'boolean') {
+                    if (input.includes('alias')) {
+                      input = input.replace(`}`, `, transform: booleanAttribute }`);


To fix the problem, we need to ensure that all occurrences of the substring } are replaced, not just the first one. This can be achieved by using a regular expression with the global flag (g). This change will ensure that the replacement is applied to all instances of the substring within the string.

Specifically, we will modify the input.replace call on line 391 to use a regular expression with the global flag. This change will be made in the file tools/eslint/angular-generator-rule.ts.

tools/eslint/angular-generator-rule.ts

+                    }
+                  } else if (member.type.getText() === 'number') {
+                    if (input.includes('alias')) {
+                      input = input.replace(`}`, `, transform: numberAttribute }`);


To fix the problem, we need to ensure that all occurrences of the string to be replaced are handled. This can be achieved by using a regular expression with the global flag (g). Specifically, we will replace the input.replace call with a regular expression to ensure that all instances of the matched string are replaced.

tools/eslint/angular-generator-rule.ts

+                  if (paramType) {
+                    if (paramType.getText() === 'boolean') {
+                      if (input.includes('alias')) {
+                        input = input.replace(`}`, `, transform: booleanAttribute }`);


To fix the problem, we need to ensure that all occurrences of the string to be replaced are handled. This can be achieved by using a regular expression with the global flag. Specifically, we will replace the input.replace call with a version that uses a regular expression to replace all occurrences of the string.

tools/eslint/angular-generator-rule.ts

+                      }
+                    } else if (paramType.getText() === 'number') {
+                      if (input.includes('alias')) {
+                        input = input.replace(`}`, `, transform: numberAttribute }`);


To fix the problem, we need to ensure that all occurrences of the string to be replaced are handled. This can be achieved by using a regular expression with the global flag. Specifically, we will replace the input.replace call with a version that uses a regular expression to match all occurrences of the closing curly brace }.

jeripeierSBB · 2024-12-24T13:58:22Z

@DavideMininni-Fincons Could this PR be closed?

DavideMininni-Fincons · 2025-01-07T08:25:46Z

PR closed: this feature will be implemented in sbb-design-systems/lyne-angular#1

kyubisation and others added 17 commits October 22, 2024 16:13

feat: create angular wrapper library

d6ac87d

build: implement Angular generator as eslint rule

1e29a00

chore: generate empty Angular files

40d4c4a

fix: integrity

70950dd

chore: minor fixes on angular-generator-rule.ts

55ff7ed

chore: add get/set for input

21d7e8b

Merge remote-tracking branch 'origin/main' into feat-angular-wrapper

b755059

# Conflicts: # package.json # yarn.lock

feat: test for retrieve imports

e91d964

Revert "feat: test for retrieve imports"

4e5b405

This reverts commit e91d964.

feat: mixin migration (TBC)

1e510ac

Merge remote-tracking branch 'origin/main' into feat-angular-wrapper

51b2b56

# Conflicts: # package.json # src/elements/file-selector/file-selector.ts # src/elements/radio-button/radio-button-group/radio-button-group.ts # yarn.lock

feat: add mixins outside core folder

97e9c54

feat: add base classes

6454293

feat: add logic for output

50aada1

feat: add logic for methods

297caee

feat: add logic for get/set

138e91d

feat: add logic for inheritance

7a2a44d

DavideMininni-Fincons requested review from TomMenga, MarioCastigliano and dauriamarco December 2, 2024 11:05

DavideMininni-Fincons added 2 commits December 2, 2024 14:13

fix: remove generate-angular-wrapper.ts

8cd6ceb

fix: imports

1ebcc51

jeripeierSBB reviewed Dec 3, 2024

View reviewed changes

DavideMininni-Fincons added 3 commits December 3, 2024 11:11

fix: review

b279c56

Merge remote-tracking branch 'origin/main' into feat-angular-wrapper

41705ae

# Conflicts: # package.json # yarn.lock

fix: merge from main

d93b28a

github-advanced-security bot found potential problems Dec 3, 2024

View reviewed changes

tools/eslint/angular-generator-rule.ts Fixed Show fixed Hide fixed

tools/eslint/angular-generator-rule.ts Fixed Show fixed Hide fixed

kyubisation reviewed Dec 3, 2024

View reviewed changes

fix: unique excluded mixin case

09e036c

DavideMininni-Fincons added 13 commits December 5, 2024 10:22

feat: generate component (partial)

4672eed

feat: fix script, generate component (partial)

7946bc0

feat: fix script, generate component (partial)

092b8b3

feat: fix script, generate component (partial)

812b8db

feat: fix script, generate component (partial)

9c2f2cb

feat: fix mixins, generate component (partial)

de873a4

feat: fix mixins, generate component (partial)

a2f8553

feat: fix script, fix generated components, generate components (part…

025e0fb

…ial)

feat: generate components

2f5ba2e

Merge remote-tracking branch 'origin/main' into feat-angular-wrapper

445fd88

# Conflicts: # package.json # yarn.lock

fix: merge

483459b

fix: imports

e8a50a5

fix: minor fixes

f31c44a

github-advanced-security bot found potential problems Dec 9, 2024

View reviewed changes

DavideMininni-Fincons added 4 commits December 9, 2024 16:10

fix: imports

dd6e075

fix: imports

05b7c85

fix: imports

df570fe

fix: minor fixes

262d3ae

DavideMininni-Fincons marked this pull request as ready for review December 9, 2024 16:11

github-actions bot added the pr: peer review required A peer review is required for this pull request label Dec 9, 2024

DavideMininni-Fincons added 2 commits December 9, 2024 17:16

fix: imports

8948387

fix: lint

13bdde0

DavideMininni-Fincons closed this Jan 7, 2025

github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jan 7, 2025

@@ -390,3 +390,3 @@
                                 if (input.includes('alias')) {
-                                  input = input.replace(`}`, `, transform: booleanAttribute }`);
+                                  input = input.replace(/}/g, `, transform: booleanAttribute }`);
                                 } else {

@@ -390,3 +390,3 @@
                                 if (input.includes('alias')) {
-                                  input = input.replace(`}`, `, transform: booleanAttribute }`);
+                                  input = input.replace(/}/g, `, transform: booleanAttribute }`);
                                 } else {
@@ -396,3 +396,3 @@
                                 if (input.includes('alias')) {
-                                  input = input.replace(`}`, `, transform: numberAttribute }`);
+                                  input = input.replace(/}/g, `, transform: numberAttribute }`);
                                 } else {

@@ -455,3 +455,3 @@
                                   if (input.includes('alias')) {
-                                    input = input.replace(`}`, `, transform: booleanAttribute }`);
+                                    input = input.replace(/}/g, `, transform: booleanAttribute }`);
                                   } else {
@@ -461,3 +461,3 @@
                                   if (input.includes('alias')) {
-                                    input = input.replace(`}`, `, transform: numberAttribute }`);
+                                    input = input.replace(/}/g, `, transform: numberAttribute }`);
                                   } else {

@@ -455,3 +455,3 @@
                                   if (input.includes('alias')) {
-                                    input = input.replace(`}`, `, transform: booleanAttribute }`);
+                                    input = input.replace(/}/g, `, transform: booleanAttribute }`);
                                   } else {
@@ -461,3 +461,3 @@
                                   if (input.includes('alias')) {
-                                    input = input.replace(`}`, `, transform: numberAttribute }`);
+                                    input = input.replace(/}/g, `, transform: numberAttribute }`);
                                   } else {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Angular wrapper #3267

feat: add Angular wrapper #3267

DavideMininni-Fincons commented Dec 2, 2024

jeripeierSBB left a comment

jeripeierSBB Dec 3, 2024

jeripeierSBB Dec 3, 2024

jeripeierSBB Dec 3, 2024

jeripeierSBB Dec 3, 2024

jeripeierSBB Dec 3, 2024

jeripeierSBB Dec 3, 2024

kyubisation left a comment

DavideMininni-Fincons commented Dec 4, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

jeripeierSBB commented Dec 24, 2024

DavideMininni-Fincons commented Jan 7, 2025 •

edited

Loading

	"@angular-devkit/build-angular": "^18.2.3",
	"@angular-devkit/build-angular": "18.2.3",

		@@ -0,0 +1,10 @@
		// TODO check if makes sense or they are just duplicated and possibily remove.

	// TODO check if makes sense or they are just duplicated and possibily remove.
	// TODO: check if makes sense or they are just duplicated and can possibily be removed.

feat: add Angular wrapper #3267

feat: add Angular wrapper #3267

Conversation

DavideMininni-Fincons commented Dec 2, 2024

jeripeierSBB left a comment

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

jeripeierSBB Dec 3, 2024

Choose a reason for hiding this comment

kyubisation left a comment

Choose a reason for hiding this comment

DavideMininni-Fincons commented Dec 4, 2024

jeripeierSBB commented Dec 24, 2024

DavideMininni-Fincons commented Jan 7, 2025 • edited Loading

DavideMininni-Fincons commented Jan 7, 2025 •

edited

Loading