-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pearl-chain): implement new component structure #3172
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
src/elements/pearl-chain/pearl-chain-leg/pearl-chain-leg.visual.spec.ts
Outdated
Show resolved
Hide resolved
|
||
## States | ||
|
||
The `past`, `arrival-skipped`, `departure-skipped`, and `disruption` properties are connected to the self-named states. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some extra info about what happens when these params are set would be helpful (e.g. what is rendered when)
src/elements/pearl-chain/pearl-chain/pearl-chain.visual.spec.ts
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,107 @@ | |||
import { html } from 'lit'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forced colors tests?
Preflight Checklist
Issue
This PR Closes #2335
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information