refactor(pearl-chain): implement new component structure #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCastigliano
added
the
pr: peer review required
src/elements/pearl-chain/pearl-chain-leg/pearl-chain-leg.visual.spec.ts
Outdated
Show resolved
Hide resolved
|
|
||
| ## States | ||
|
|
||
| The `past`, `arrival-skipped`, `departure-skipped`, and `disruption` properties are connected to the self-named states. |
There was a problem hiding this comment.
Some extra info about what happens when these params are set would be helpful (e.g. what is rendered when)
src/elements/pearl-chain/pearl-chain/pearl-chain.visual.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,107 @@ | |||
| import { html } from 'lit'; | |||
There was a problem hiding this comment.
Forced colors tests?
src/elements/pearl-chain/pearl-chain/pearl-chain.sample-data.ts
Outdated
Show resolved
Hide resolved
MarioCastigliano
requested review from
kyubisation and
jeripeierSBB
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preflight Checklist
Issue
This PR Closes #2335
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information