Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-loading-indicator): center component into his box #3144

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Oct 4, 2024

NOTE: where does the original -3em value come from?

@DavideMininni-Fincons DavideMininni-Fincons changed the title fix: clean useless variable, fix position [WIP] fix(sbb-loading-indicator): center component into his box [WIP] Oct 4, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title fix(sbb-loading-indicator): center component into his box [WIP] fix(sbb-loading-indicator): center component into his box Oct 7, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Oct 7, 2024
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Oct 7, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 22978f6 into main Oct 8, 2024
39 of 40 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the fix/bug-sbb-loading-indicator branch October 8, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: loading indicator size small bleeds out of its bounding boxes
2 participants