Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-paginator): add sbb-compact-paginator component variant #3142

Merged
merged 26 commits into from
Oct 24, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Oct 4, 2024

Preflight Checklist

Issue

This PR Closes #3056

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add a common mixin class and refactored the sbb-paginator to a new folder
  • add sbb-compact-paginator component

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to pr3142 October 4, 2024 10:26 Inactive
@github-actions github-actions bot temporarily deployed to pr3142-diff October 4, 2024 10:27 Inactive
@github-actions github-actions bot temporarily deployed to pr3142 October 4, 2024 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pr3142-diff October 4, 2024 13:26 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat: add sbb-compact-paginator component [WIP] feat: add sbb-compact-paginator component Oct 4, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Oct 4, 2024
@github-actions github-actions bot temporarily deployed to pr3142 October 23, 2024 08:39 Inactive
@github-actions github-actions bot temporarily deployed to pr3142-diff October 23, 2024 08:39 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! A few small stuff left :)

src/elements/paginator/common/paginator-common.ts Outdated Show resolved Hide resolved
src/elements/paginator/common/paginator-common.ts Outdated Show resolved Hide resolved
src/elements/paginator/common/paginator-common.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr3142 October 23, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to pr3142-diff October 23, 2024 15:42 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your great work

@DavideMininni-Fincons DavideMininni-Fincons merged commit 2f3dc21 into main Oct 24, 2024
19 of 20 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/sbb-compact-paginator branch October 24, 2024 08:23
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Oct 24, 2024
This was referenced Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story(sbb-compact-paginator): variant implementation
3 participants