Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-paginator): add disabled property #3130

Merged
merged 5 commits into from
Oct 17, 2024
Merged

feat(sbb-paginator): add disabled property #3130

merged 5 commits into from
Oct 17, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Oct 1, 2024 •
edited by jeripeierSBB
Loading

No description provided.

jeripeierSBB
jeripeierSBB reviewed Oct 1, 2024
View reviewed changes
src/elements/paginator/paginator.scss Outdated Show resolved Hide resolved
src/elements/paginator/paginator.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr3130 October 1, 2024 12:49 Inactive
@github-actions github-actions bot temporarily deployed to pr3130-diff October 1, 2024 12:49 Inactive
@DavideMininni-Fincons DavideMininni-Fincons linked an issue Oct 3, 2024 that may be closed by this pull request
story(sbb-paginator): disabling paginator #3061
Closed
@jeripeierSBB jeripeierSBB changed the title feat(sbb-paginator): add disabled prop [WIP] feat(sbb-paginator): add disabled property Oct 3, 2024
jeripeierSBB
jeripeierSBB approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request pr: lead review approved Pull request has been approved by a lead review labels Oct 3, 2024
@github-actions github-actions bot temporarily deployed to pr3130 October 3, 2024 09:25 Inactive
@github-actions github-actions bot temporarily deployed to pr3130-diff October 3, 2024 09:25 Inactive
@DavideMininni-Fincons DavideMininni-Fincons added the pr: blocked Pull request is blocked either for merging or reviewing label Oct 4, 2024
@DavideMininni-Fincons DavideMininni-Fincons added pr: ux review required A ux review is required for this pull request and removed pr: blocked Pull request is blocked either for merging or reviewing labels Oct 16, 2024
@mcilurzo
Copy link
Contributor

LGTM. Thank you.

@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Oct 17, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit d43f64c into main Oct 17, 2024
28 of 29 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/sbb-paginator-disabled branch October 17, 2024 08:29
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Oct 17, 2024
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

story(sbb-paginator): disabling paginator
3 participants
@DavideMininni-Fincons @mcilurzo @jeripeierSBB