Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid compiling CSS comments #3124

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Sep 30, 2024

SCSS /* comments are getting compiled into CSS. Having such comments in mixins generates a lot of redundant output. With the stylelint rule, we can avoid it.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Oct 1, 2024
@jeripeierSBB jeripeierSBB merged commit 8ff7b7c into main Oct 1, 2024
30 checks passed
@jeripeierSBB jeripeierSBB deleted the avoid-compiling-css-comments branch October 1, 2024 08:35
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants